linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Stephane Eranian <eranian@google.com>
To: Anshuman Khandual <khandual@linux.vnet.ibm.com>
Cc: Michael Neuling <mikey@neuling.org>,
	"ak@linux.intel.com" <ak@linux.intel.com>,
	Peter Zijlstra <peterz@infradead.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Linux PPC dev <linuxppc-dev@ozlabs.org>,
	Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH 4/5] x86, perf: Add conditional branch filtering support
Date: Thu, 23 May 2013 15:38:20 +0200	[thread overview]
Message-ID: <CABPqkBTP+eP8hMsL=HWJHUjK-pup_Q8OGUtJ7RSFXg1=SssrFA@mail.gmail.com> (raw)
In-Reply-To: <1369203761-12649-5-git-send-email-khandual@linux.vnet.ibm.com>

On Wed, May 22, 2013 at 8:22 AM, Anshuman Khandual
<khandual@linux.vnet.ibm.com> wrote:
> From: Peter Zijlstra <a.p.zijlstra@chello.nl>
>
> This patch adds conditional branch filtering support,
> enabling it for PERF_SAMPLE_BRANCH_COND in perf branch
> stack sampling framework by utilizing an available
> software filter X86_BR_JCC.
>
Reviewed-by: Stephane Eranian <eranian@google.com>

> Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Signed-off-by: Anshuman Khandual <khandual@linux.vnet.ibm.com>
> ---
>  arch/x86/kernel/cpu/perf_event_intel_lbr.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/arch/x86/kernel/cpu/perf_event_intel_lbr.c b/arch/x86/kernel/cpu/perf_event_intel_lbr.c
> index d978353..a0d6387 100644
> --- a/arch/x86/kernel/cpu/perf_event_intel_lbr.c
> +++ b/arch/x86/kernel/cpu/perf_event_intel_lbr.c
> @@ -337,6 +337,10 @@ static int intel_pmu_setup_sw_lbr_filter(struct perf_event *event)
>
>         if (br_type & PERF_SAMPLE_BRANCH_IND_CALL)
>                 mask |= X86_BR_IND_CALL;
> +
> +       if (br_type & PERF_SAMPLE_BRANCH_COND)
> +               mask |= X86_BR_JCC;
> +
>         /*
>          * stash actual user request into reg, it may
>          * be used by fixup code for some CPU
> @@ -626,6 +630,7 @@ static const int nhm_lbr_sel_map[PERF_SAMPLE_BRANCH_MAX] = {
>          * NHM/WSM erratum: must include IND_JMP to capture IND_CALL
>          */
>         [PERF_SAMPLE_BRANCH_IND_CALL] = LBR_IND_CALL | LBR_IND_JMP,
> +       [PERF_SAMPLE_BRANCH_COND]     = LBR_JCC,
>  };
>
>  static const int snb_lbr_sel_map[PERF_SAMPLE_BRANCH_MAX] = {
> @@ -637,6 +642,7 @@ static const int snb_lbr_sel_map[PERF_SAMPLE_BRANCH_MAX] = {
>         [PERF_SAMPLE_BRANCH_ANY_CALL]   = LBR_REL_CALL | LBR_IND_CALL
>                                         | LBR_FAR,
>         [PERF_SAMPLE_BRANCH_IND_CALL]   = LBR_IND_CALL,
> +       [PERF_SAMPLE_BRANCH_COND]       = LBR_JCC,
>  };
>
>  /* core */
> --
> 1.7.11.7
>

  reply	other threads:[~2013-05-23 13:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-22  6:22 [PATCH 0/5] perf: Introducing new conditional branch filter Anshuman Khandual
2013-05-22  6:22 ` [PATCH 1/5] perf: New conditional branch filter criteria in branch stack sampling Anshuman Khandual
2013-05-23 13:36   ` Stephane Eranian
2013-05-22  6:22 ` [PATCH 2/5] powerpc, perf: Enable conditional branch filter for POWER8 Anshuman Khandual
2013-05-22  7:53   ` Peter Zijlstra
2013-05-22 10:20     ` Michael Neuling
2013-05-22  6:22 ` [PATCH 3/5] perf, tool: Conditional branch filter 'cond' added to perf record Anshuman Khandual
2013-05-22  6:22 ` [PATCH 4/5] x86, perf: Add conditional branch filtering support Anshuman Khandual
2013-05-23 13:38   ` Stephane Eranian [this message]
2013-05-22  6:22 ` [PATCH 5/5] perf, documentation: Description for conditional branch filter Anshuman Khandual
2013-05-23 13:39   ` Stephane Eranian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABPqkBTP+eP8hMsL=HWJHUjK-pup_Q8OGUtJ7RSFXg1=SssrFA@mail.gmail.com' \
    --to=eranian@google.com \
    --cc=ak@linux.intel.com \
    --cc=khandual@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=mikey@neuling.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).