Re: [PATCH] powerpc/xics: Set the IRQ chip data for the ICS native backend

[Joel Stanley <joel@jms.id.au>]

On Mon, 13 Sept 2021 at 13:48, Cédric Le Goater <clg@kaod.org> wrote:
>
> The ICS native driver relies on the IRQ chip data to find the struct
> 'ics_native' describing the ICS controller but it was removed by commit
> 248af248a8f4 ("powerpc/xics: Rename the map handler in a check handler").
> Revert this change to fix the Microwatt SoC platform.
>
> Fixes: 248af248a8f4 ("powerpc/xics: Rename the map handler in a check handler")
> Signed-off-by: Cédric Le Goater <clg@kaod.org>

Reviewed-by: Joel Stanley <joel@jms.id.au>

Thanks Cédric.

> ---
>  arch/powerpc/sysdev/xics/xics-common.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/sysdev/xics/xics-common.c b/arch/powerpc/sysdev/xics/xics-common.c
> index 5c1a157a83b8..244a727c6ba4 100644
> --- a/arch/powerpc/sysdev/xics/xics-common.c
> +++ b/arch/powerpc/sysdev/xics/xics-common.c
> @@ -348,9 +348,9 @@ static int xics_host_map(struct irq_domain *domain, unsigned int virq,
>         if (xics_ics->check(xics_ics, hwirq))
>                 return -EINVAL;
>
> -       /* No chip data for the XICS domain */
> +       /* Let the ICS be the chip data for the XICS domain. For ICS native */
>         irq_domain_set_info(domain, virq, hwirq, xics_ics->chip,
> -                           NULL, handle_fasteoi_irq, NULL, NULL);
> +                           xics_ics, handle_fasteoi_irq, NULL, NULL);
>
>         return 0;
>  }
> --
> 2.31.1
>