From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF78FC282CE for ; Tue, 4 Jun 2019 20:31:07 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 27DE020874 for ; Tue, 4 Jun 2019 20:31:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 27DE020874 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 45JNqF2QvdzDqW0 for ; Wed, 5 Jun 2019 06:31:05 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gmail.com (client-ip=209.85.167.193; helo=mail-oi1-f193.google.com; envelope-from=pku.leo@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=fail (p=none dis=none) header.from=nxp.com Received: from mail-oi1-f193.google.com (mail-oi1-f193.google.com [209.85.167.193]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 45JNnZ3Z2JzDqR3 for ; Wed, 5 Jun 2019 06:29:38 +1000 (AEST) Received: by mail-oi1-f193.google.com with SMTP id q186so16633193oia.0 for ; Tue, 04 Jun 2019 13:29:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ShuaCglHMPdgyal6GGIwZRaEUD77Ogg+O3HSaYQ63/E=; b=nEUqFsC/wKx9nfmvUGVq1/zbGpFNJ6NLA/cdxPzqC3QyWSYL07KAAL3LoAGR5F+J4A ZBcdz4wPu6rpYP41A4yis1RmjRQfiW3XeQEztcUHqoTL9DBwSO+2oJO64nSCE8yfgbCR YwdKIeREwksVAqJQYCiy5QoT5TPo8WHT10Rg7BLtqIrd9jojG/aVqmvXRQ30NHA6qCJ4 geWm+Iu5W9Ns027y3WYGIOHczcscyqY7Q/DitNHGVqRsVzy+TmbUAzQHHJcScJp26WL4 QfiQjnIsPIIfkZB++yERy7Nk/KyGKgzNZqvYgguobSaV/mSoYhl0hVoCo4ClCXqX/Mw3 VjYQ== X-Gm-Message-State: APjAAAV9OJsgASMCsptfNVSaJAR2J/SrldKBFEHHvfKoin3w12sxWv2R +Ck0Hzo5NBAadhRmxiKwI5tKg+zZIm4= X-Google-Smtp-Source: APXvYqx1IbthGyXA78DuHou4nFBVq1EFPjKV93u1NgcR5poDl31LTXP3kkbcnYXz5+hwu29G7wpoew== X-Received: by 2002:aca:5bd6:: with SMTP id p205mr5534173oib.67.1559680174927; Tue, 04 Jun 2019 13:29:34 -0700 (PDT) Received: from mail-ot1-f42.google.com (mail-ot1-f42.google.com. [209.85.210.42]) by smtp.gmail.com with ESMTPSA id g16sm6192442otl.40.2019.06.04.13.29.33 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Jun 2019 13:29:34 -0700 (PDT) Received: by mail-ot1-f42.google.com with SMTP id l15so1093479otn.9 for ; Tue, 04 Jun 2019 13:29:33 -0700 (PDT) X-Received: by 2002:a9d:6058:: with SMTP id v24mr441623otj.110.1559680173629; Tue, 04 Jun 2019 13:29:33 -0700 (PDT) MIME-Version: 1.0 References: <20190501092841.9026-1-rasmus.villemoes@prevas.dk> <20190513111442.25724-1-rasmus.villemoes@prevas.dk> In-Reply-To: <20190513111442.25724-1-rasmus.villemoes@prevas.dk> From: Li Yang Date: Tue, 4 Jun 2019 15:29:22 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 0/6] soc/fsl/qe: cleanups and new DT binding To: Rasmus Villemoes Content-Type: text/plain; charset="UTF-8" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "devicetree@vger.kernel.org" , Scott Wood , "linux-kernel@vger.kernel.org" , Rasmus Villemoes , Rob Herring , "linuxppc-dev@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" , Qiang Zhao Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, May 13, 2019 at 6:17 AM Rasmus Villemoes wrote: > > This small series consists of some small cleanups and simplifications > of the QUICC engine driver, and introduces a new DT binding that makes > it much easier to support other variants of the QUICC engine IP block > that appears in the wild: There's no reason to expect in general that > the number of valid SNUMs uniquely determines the set of such, so it's > better to simply let the device tree specify the values (and, > implicitly via the array length, also the count). > > Which tree should this go through? > > v3: > - Move example from commit log into binding document (adapting to > MPC8360 which the existing example pertains to). > - Add more review tags. > - Fix minor style issue. > > v2: > - Address comments from Christophe Leroy > - Add his Reviewed-by to 1/6 and 3/6 > - Split DT binding update to separate patch as per > Documentation/devicetree/bindings/submitting-patches.txt > > Rasmus Villemoes (6): > soc/fsl/qe: qe.c: drop useless static qualifier > soc/fsl/qe: qe.c: reduce static memory footprint by 1.7K > soc/fsl/qe: qe.c: introduce qe_get_device_node helper > dt-bindings: soc/fsl: qe: document new fsl,qe-snums binding > soc/fsl/qe: qe.c: support fsl,qe-snums property > soc/fsl/qe: qe.c: fold qe_get_num_of_snums into qe_snums_init Series applied to soc/fsl for-next. Thanks! Regards, Leo > > .../devicetree/bindings/soc/fsl/cpm_qe/qe.txt | 13 +- > drivers/soc/fsl/qe/qe.c | 163 +++++++----------- > 2 files changed, 77 insertions(+), 99 deletions(-) > > -- > 2.20.1 >