Re: [PATCH] Fix function keys sequence on USB

[Dinar Valeev <k0da@opensuse.org>]

On Tue, Jun 2, 2015 at 1:12 PM, Thomas Huth <thuth@redhat.com> wrote:
> On Tue, 2 Jun 2015 12:43:16 +0200
> Dinar Valeev <k0da@opensuse.org> wrote:
>
>> On Tue, Jun 2, 2015 at 12:29 PM, Nikunj A Dadhania
>> <nikunj@linux.vnet.ibm.com> wrote:
>> > Dinar Valeev <k0da@opensuse.org> writes:
>> >
>> >> On Tue, Jun 2, 2015 at 11:47 AM, Nikunj A Dadhania
>> >> <nikunj@linux.vnet.ibm.com> wrote:
>> >>> Dinar valeev <k0da@opensuse.org> writes:
> ...
>> >>>> @@ -290,36 +286,34 @@ static void check_key_code(uint8_t *buf)
>> >>>>                               case 0x49:
>> >>>>                                       write_key(0x1b);               /* INS */
>> >>>>                                       write_key(0x5b);
>> >>>> -                                     write_key(0x31);
>> >>>> +                                     write_key(0x32);
>> >>>>                                       write_key(0x7e);
>> >>>>                                       break;
>> >>>>
>> >>>>                               case 0x4a:
>> >>>>                                       write_key(0x1b);              /* HOME */
>> >>>>                                       write_key(0x5b);
>> >>>> -                                     write_key(0x32);
>> >>>> -                                     write_key(0x7e);
>> >>>> +                                     write_key(0x48);
>> >>>
>> >>> Looking at accept.fs - handle-ESC-5b ...
>> >>>
>> >>> : handle-ESC-5b
>> >>>    key
>> >>>    dup 31 = IF \ HOME
>> >>>       key drop ( drops closing 7e ) handle-^A
>> >>>    ELSE
>> >>>       dup 33 = IF \ DEL
>> >>>          key drop handle-^D
>> >>>       ELSE
>> >>>          dup 34 = IF \ END
>> >>>             key drop handle-^E
>> >>>          ELSE
>> >>>             dup 1f and handle-CSI
>> >>>          THEN
>> >>>       THEN
>> >>>    THEN drop
>> >>> ;
>> >>>
>> >>>
>> >>> ... following change is sufficient:
>> >>> -                                       write_key(0x32);
>> >>> +                                       write_key(0x31);
>> >>>
>> >> Home sequence for me is: ^[[H
>> >
>> > Can you check the above change in your setup ?
>> That works as well.
>
> Not sure, but IIRC some of these key codes depend on the keyboard
> layout that you are using. What keyboard layout (i.e. language) do
> you use?
en_us, but note that "End" issue was found by running qemu as part of
openQA (plain qemu). This is how we test distribution.
We're sending keyboard,mouse commands over ui/vnc.
>
>  Thomas