Re: [PATCH 2/2] PCI: pciehp: Convert pciehp to be builtin only, not modular

[Yinghai Lu <yinghai@kernel.org>]

On Fri, Jul 26, 2013 at 5:43 AM, Yinghai Lu <yinghai@kernel.org> wrote:
> On Thu, Jul 25, 2013 at 10:57 AM, Bjorn Helgaas <bhelgaas@google.com> wrote:
>> Convert pciehp to be builtin only, with no module option.
>>
>> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
>> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>> ---
>>  drivers/pci/pcie/Kconfig |    5 +----
>>  1 file changed, 1 insertion(+), 4 deletions(-)
>>
>> diff --git a/drivers/pci/pcie/Kconfig b/drivers/pci/pcie/Kconfig
>> index 569f82f..3b94cfc 100644
>> --- a/drivers/pci/pcie/Kconfig
>> +++ b/drivers/pci/pcie/Kconfig
>> @@ -14,15 +14,12 @@ config PCIEPORTBUS
>>  # Include service Kconfig here
>>  #
>>  config HOTPLUG_PCI_PCIE
>> -       tristate "PCI Express Hotplug driver"
>> +       bool "PCI Express Hotplug driver"
>>         depends on HOTPLUG_PCI && PCIEPORTBUS
>>         help
>>           Say Y here if you have a motherboard that supports PCI Express Native
>>           Hotplug
>>
>> -         To compile this driver as a module, choose M here: the
>> -         module will be called pciehp.
>> -
>>           When in doubt, say N.
>>
>>  source "drivers/pci/pcie/aer/Kconfig"
>>
>
> Acked-by: Yinghai Lu <yinghai@kernel.org>

Hi Bjorn,

Looks like we lose the option to disable pciehp after we make it as built-in.

Before acpiphp and pciehp could be compiled as modules, and user could
blacklist to disable them.

Now they are all built-in, but only acpiphp has acpiphp.disable to
disable acpiphp.
we don't have pciehp.disable yet.

Do you think if we should add pciehp.disable ?

BTW we don't have any description for acpiphp.disable anywhere.

Thanks

Yinghai