From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93478C004C9 for ; Tue, 7 May 2019 06:51:16 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 13C9F20C01 for ; Tue, 7 May 2019 06:51:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MbpgTNQu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 13C9F20C01 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 44yqy94wdvzDqNn for ; Tue, 7 May 2019 16:51:13 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::741; helo=mail-qk1-x741.google.com; envelope-from=green.hu@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="MbpgTNQu"; dkim-atps=neutral Received: from mail-qk1-x741.google.com (mail-qk1-x741.google.com [IPv6:2607:f8b0:4864:20::741]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 44yqwb3CGBzDqHk for ; Tue, 7 May 2019 16:49:47 +1000 (AEST) Received: by mail-qk1-x741.google.com with SMTP id a64so3646165qkg.5 for ; Mon, 06 May 2019 23:49:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=pa7Box1aR7yFtR1LX1WDnV3kRpU7SqZCsbjs49Q3I5I=; b=MbpgTNQuafLtAS2Dly735CRfwi2rTUQf2u2v4oGvQgQgSYIdnRpg7VCLomPpMzIscG QaTnC9SQ9ku6gzFOzq1s9XrRaJmYor/1LFKrkhizBLNXIXufH7ZYafVfUTi/hxmPPuHk B/SkK/YRJGmYzfaQ1xghtxinwaerdxpRKizUfkuezccasVKNLUKgHxlEEtCQzs7jj3xl zQkJPXfNNvA3TqInSISCOxmMnYUjkdAFYUZlvI0ouvwsL+dfg4OFY2WIgIiVzRvRisWc 5DS8N2wLUkGet8qbU+i0bfGDKHxX5peC2gXK9w9E6zQg9z2uNJlAWgMxSlSz/L/CQjSl IVaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=pa7Box1aR7yFtR1LX1WDnV3kRpU7SqZCsbjs49Q3I5I=; b=EdgfxYhlDlB9Lb/dizKJskwbok3f2gsMJtJzUX2vyL6rvveFc3Qx32UueBqDqehkRU mICWwMEY5xFFRU/ePBSitCCyMAezHKGZeztuz4e1H7wszrZmGj+Cxui1+wowVU7Xi7Zz FVEl2WIsSXUcBGB93jEqvW60VJUa8GFDuq5Wz9vltncbBNlWvRbsLNdQAC4LtLuHo/8g Km6oCS2GkdEvBxKimAZfuE67QmAmCxkVDKgixp3uSv+tFOi/Dk5M9CUVUO0cYWYQvqYS rU90mvYkxKSqmjBbmnJGIk+4frEpz3Y2OgWV7FbtYkcvEoXUKS5PBLNTjLAsEy3W89mf v6qQ== X-Gm-Message-State: APjAAAUVrSEZd/xufgcPrRPfM5IobWVL7Z8l4O9QUayVcyJV1LXazqU1 QXWCvKWeK5YTN6QnEru7fc5xxuyqd6dAvIdFJ6A= X-Google-Smtp-Source: APXvYqzuoQEtPiGnZXwYeWTvh/tWnA2kNb3EmE2Gn3p8SIpj/ShNUcDydJeqXgxDTOHN1axGtXmE2eyXjqUTKs09l0U= X-Received: by 2002:a05:620a:1012:: with SMTP id z18mr1671111qkj.205.1557211784520; Mon, 06 May 2019 23:49:44 -0700 (PDT) MIME-Version: 1.0 References: <1556810922-20248-1-git-send-email-rppt@linux.ibm.com> <1556810922-20248-10-git-send-email-rppt@linux.ibm.com> In-Reply-To: <1556810922-20248-10-git-send-email-rppt@linux.ibm.com> From: Greentime Hu Date: Tue, 7 May 2019 14:49:08 +0800 Message-ID: Subject: Re: [PATCH 09/15] nds32: switch to generic version of pte allocation To: Mike Rapoport Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michal Hocko , Catalin Marinas , Palmer Dabbelt , linux-mips@vger.kernel.org, Guo Ren , linux-hexagon@vger.kernel.org, linux-riscv@lists.infradead.org, linux-arch , Richard Weinberger , Helge Deller , x86@kernel.org, Russell King , Matthew Wilcox , Geert Uytterhoeven , Matt Turner , Sam Creasey , Arnd Bergmann , linux-um@lists.infradead.org, linux-m68k@lists.linux-m68k.org, nios2-dev@lists.rocketboards.org, Guan Xuetao , linux-arm-kernel@lists.infradead.org, linux-parisc@vger.kernel.org, Linux Kernel Mailing List , Richard Kuo , Paul Burton , linux-alpha@vger.kernel.org, Ley Foon Tan , Andrew Morton , linuxppc-dev Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi Mike, Mike Rapoport =E6=96=BC 2019=E5=B9=B45=E6=9C=882=E6=97= =A5 =E9=80=B1=E5=9B=9B =E4=B8=8B=E5=8D=8811:30=E5=AF=AB=E9=81=93=EF=BC=9A > > The nds32 implementation of pte_alloc_one_kernel() differs from the gener= ic > in the use of __GFP_RETRY_MAYFAIL flag, which is removed after the > conversion. > > The nds32 version of pte_alloc_one() missed the call to pgtable_page_ctor= () > and also used __GFP_RETRY_MAYFAIL. Switching it to use generic > __pte_alloc_one() for the PTE page allocation ensures that page table > constructor is run and the user page tables are allocated with > __GFP_ACCOUNT. > > The conversion to the generic version of pte_free_kernel() removes the NU= LL > check for pte. > > The pte_free() version on nds32 is identical to the generic one and can b= e > simply dropped. > > Signed-off-by: Mike Rapoport > --- > arch/nds32/include/asm/pgalloc.h | 31 ++++--------------------------- > 1 file changed, 4 insertions(+), 27 deletions(-) Thanks for your patch. I'm assuming this is going in along with the rest of the patches, so I'm no= t going to add it to my tree. Acked-by: Greentime Hu