From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qc0-x22e.google.com (mail-qc0-x22e.google.com [IPv6:2607:f8b0:400d:c01::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4DD2B1A0AC8 for ; Sun, 5 Apr 2015 13:25:26 +1000 (AEST) Received: by qcrf4 with SMTP id f4so1868988qcr.0 for ; Sat, 04 Apr 2015 20:25:23 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1427857069-6789-1-git-send-email-yinghai@kernel.org> <1427857069-6789-2-git-send-email-yinghai@kernel.org> <20150403193234.GD10892@google.com> <20150403205201.GF10892@google.com> From: Bjorn Helgaas Date: Sat, 4 Apr 2015 22:25:03 -0500 Message-ID: Subject: Re: [PATCH 1/3] PCI: Introduce pci_bus_addr_t To: Rob Herring Content-Type: text/plain; charset=UTF-8 Cc: David Ahern , Russell King , Sam Ravnborg , "linux-mips@linux-mips.org" , "linux-pci@vger.kernel.org" , the arch/x86 maintainers , linuxppc-dev , "stable@vger.kernel.org" , Linux Kernel Mailing List , Ralf Baechle , "sparclinux@vger.kernel.org" , Yinghai Lu , David Miller , "linux-arm-kernel@lists.infradead.org" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sat, Apr 4, 2015 at 2:48 PM, Rob Herring wrote: > On Sat, Apr 4, 2015 at 7:46 AM, Bjorn Helgaas wrote: >> I think there's still an unresolved question about the OF parsing code. > > Got a pointer to what that is? I'll take a guess. Generally, we make > the parsing code independent of the kernel addr sizes and use u64 > types. The DT sizes and kernel sizes are not always aligned. For > example, an LPAE capable platform running a non-LPAE kernel build. Yep: http://lkml.kernel.org/r/1427857069-6789-3-git-send-email-yinghai@kernel.org Yinghai made a change to the sparc OF parsing code. The question is whether a similar change should be made to clones of that code (two others in arch/sparc, one in arch/powerpc, and one in drivers/of). Bjorn