From: McClintock Matthew-B29882 <B29882@freescale.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Gala Kumar-B11780 <B11780@freescale.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH v2] powerpc/setup_{32, 64}.c: remove unneeded boot_cpuid{, _phys}
Date: Fri, 16 Dec 2011 03:29:43 +0000 [thread overview]
Message-ID: <CAEsOVNcZPH_MJUdy0q7AjwomHTZhg2DoHSV+y9xatq-2SohC2A@mail.gmail.com> (raw)
In-Reply-To: <1324005174.4875.0.camel@pasglop>
On Thu, Dec 15, 2011 at 9:12 PM, Benjamin Herrenschmidt
<benh@kernel.crashing.org> wrote:
> On Mon, 2011-11-28 at 22:24 -0600, Matthew McClintock wrote:
>> boot_cpuid and init_thread_info.cpu are redundant, just use the
>> var that stays around longer and add a define to make boot_cpuid
>> point at the correct value
>>
>> boot_cpudid_phys is not needed and can completly go away from the
>> SMP case, we leave it there for the non-SMP case since the paca
>> struct is not around to store this info
>>
>> This patch also has the effect of having the logical cpu number
>> of the boot cpu be updated correctly independently of the ordering
>> of the cpu nodes in the device tree.
>
> So what about head_fsl_booke.S comparing boot_cpuid to -1 ? That seems
> to be broken now in at least 2 ways, boot_cpuid doesn't exist anymore
> and you don't initialize it to -1 either...
This is 4/5 which is also waiting for your review.
http://lists.ozlabs.org/pipermail/linuxppc-dev/2011-October/093474.html
-M=
next prev parent reply other threads:[~2011-12-16 3:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-25 22:54 [PATCH 1/5] powerpc/85xx: issue 15 EOI after core reset Matthew McClintock
2011-10-25 22:54 ` [PATCH 2/5] powerpc/fsl_booke: Fix comment in head_fsl_booke.S Matthew McClintock
2011-11-03 18:00 ` Kumar Gala
2011-10-25 22:54 ` [PATCH 3/5] powerpc/85xx: Make kexec to interate over online cpus Matthew McClintock
2011-11-03 18:00 ` Kumar Gala
2011-10-25 22:54 ` [PATCH 4/5] powerpc/85xx: use physical cpu from device tree Matthew McClintock
2011-10-25 22:54 ` [PATCH 5/5] powerpc/setup_{32, 64}.c: remove unneeded boot_cpuid{, _phys} Matthew McClintock
2011-11-25 3:41 ` Benjamin Herrenschmidt
2011-11-29 4:24 ` [PATCH v2] " Matthew McClintock
2011-12-16 3:12 ` Benjamin Herrenschmidt
2011-12-16 3:29 ` McClintock Matthew-B29882 [this message]
2011-12-16 3:35 ` Benjamin Herrenschmidt
2011-12-16 3:42 ` McClintock Matthew-B29882
2011-12-16 21:29 ` Scott Wood
2011-12-16 22:09 ` Benjamin Herrenschmidt
2011-12-20 18:44 ` McClintock Matthew-B29882
2011-12-20 19:27 ` Scott Wood
2011-10-26 3:16 ` [PATCH 1/5] powerpc/85xx: issue 15 EOI after core reset Kumar Gala
2011-10-26 18:13 ` [PATCH 1/5] powerpc/85xx: issue 15 EOI after core reset for FSL CoreNet devices Matthew McClintock
2011-10-26 18:30 ` Segher Boessenkool
2011-10-26 18:33 ` [PATCH v3 " Matthew McClintock
2011-10-26 18:46 ` [PATCH v4 " Matthew McClintock
2011-11-03 18:00 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEsOVNcZPH_MJUdy0q7AjwomHTZhg2DoHSV+y9xatq-2SohC2A@mail.gmail.com \
--to=b29882@freescale.com \
--cc=B11780@freescale.com \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).