From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 498DDC2BBCA for ; Fri, 21 Jun 2024 12:09:04 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=timesys-com.20230601.gappssmtp.com header.i=@timesys-com.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=f9fCT611; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4W5GNs3GX0z3bhD for ; Fri, 21 Jun 2024 22:09:01 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=timesys.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=timesys-com.20230601.gappssmtp.com header.i=@timesys-com.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=f9fCT611; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=timesys.com (client-ip=2607:f8b0:4864:20::72e; helo=mail-qk1-x72e.google.com; envelope-from=piotr.wojtaszczyk@timesys.com; receiver=lists.ozlabs.org) Received: from mail-qk1-x72e.google.com (mail-qk1-x72e.google.com [IPv6:2607:f8b0:4864:20::72e]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4W5GN44JBDz30WS for ; Fri, 21 Jun 2024 22:08:16 +1000 (AEST) Received: by mail-qk1-x72e.google.com with SMTP id af79cd13be357-797a7f9b552so104037785a.0 for ; Fri, 21 Jun 2024 05:08:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=timesys-com.20230601.gappssmtp.com; s=20230601; t=1718971694; x=1719576494; darn=lists.ozlabs.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=5CsIqk65T8h28pv7LSZHK/r+thMfNFgpmh7VKRl0UWQ=; b=f9fCT611GBQyss8sQyUwKVazH7ZiSHxo92aH768yb/aonaa4omCeHAsS2NStR91iaa sAQDqbl0nAzmTUSFdcoteFQ7/N6WkjKNE92lYyr3UcM6ottmNhPrjZgY0YQ4fPwz3Ko4 XrmqO8nDFS4Y7fagEFEwS6pYGWKDCFQGg+H5987WNUYZ4zBL+S57f85rLUG9WTz7zfeU JIkxyw5PvdOTrQ7ctDTK3FLQBhPrng8QdKuYslmujiIFHAIPk5ZtmofdTGBtHhf6pNyy XiYP8tQxE6XtQX3TN5eTOe5wTpouK1zq0ay/lMtgbDnygtNAUhrRDTDIzdA73OI2f2Ha eUeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718971694; x=1719576494; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5CsIqk65T8h28pv7LSZHK/r+thMfNFgpmh7VKRl0UWQ=; b=jK8Ia518HwR0FAG75punmGzVt1pUDQdClXzhzI/5iVF//OrL6MezKqoPzSJUP/S4gZ dp+w+9ZsQr7GKtYl2LXnRDlZI4MjMUYere80XjfXjVVaMylBSk0Hgv4uPCKfXYSiWlUJ NP8Fdbtkxj+LOaaOOuwCZHlAFrqYbr8ufUV4drT8acac2+x8whhaWGN01QxWixFcF26Q sNlyKxxRkI858glfqul1gv0nHB+ABs2z8txgpVW9Emma3dg1Dd0OPz7uypACa00EyC52 fO1zyCuTWY4ibFd6wbvcHUt1NbIXhOOo+ORUg0iezS+tEIyfTJ3vnR33fqFdhuqa2qnP RLSg== X-Forwarded-Encrypted: i=1; AJvYcCWRoH1HBa+knARW1GkCaWYL8lrMNSz5RY9CB3hINI9HY4WWMIFYU2xGxv9qntEkb6tnxVON6HFb5Tt10PRNhQ9xkIgmZPEtEIhg2wroCA== X-Gm-Message-State: AOJu0YwQSRxyGTyNoTDW665QTV1ar6ZqMZbcA77HCIhJh2ZPLYMqLScg rfojVRN8t0k+Y175QYhN3Vy98R58MnLpJO8eomaAsgISF18zfMo4hQaWk1QqIuyNiS+MIvh3yHM Cup0oCdbBSFJ+BB6J86bmmLiVsXRslPfsfle5DA== X-Google-Smtp-Source: AGHT+IH9SeiO8vfdoOxDABbDkc1VlJaHvluIQfS8YUVwP2eXorBPvqf3BAKJdJfTNAn0CNJ3/z1faNaXrP6fson02ac= X-Received: by 2002:ad4:4245:0:b0:6b0:6629:bdf9 with SMTP id 6a1803df08f44-6b501e2c710mr72849356d6.21.1718971694039; Fri, 21 Jun 2024 05:08:14 -0700 (PDT) MIME-Version: 1.0 References: <20240620175657.358273-1-piotr.wojtaszczyk@timesys.com> <20240620175657.358273-11-piotr.wojtaszczyk@timesys.com> In-Reply-To: From: Piotr Wojtaszczyk Date: Fri, 21 Jun 2024 14:08:03 +0200 Message-ID: Subject: Re: [Patch v4 10/10] i2x: pnx: Use threaded irq to fix warning from del_timer_sync() To: Andi Shyti Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, Vignesh Raghavendra , Michael Turquette , Li Zetao , Liam Girdwood , linux-mtd@lists.infradead.org, linux-i2c@vger.kernel.org, Miquel Raynal , linux-clk@vger.kernel.org, Rob Herring , Richard Weinberger , Russell King , "J.M.B. Downing" , Markus Elfring , devicetree@vger.kernel.org, Conor Dooley , Arnd Bergmann , Yangtao Li , linux-sound@vger.kernel.org, Vladimir Zapolskiy , Mark Brown , Jaroslav Kysela , linux-arm-kernel@lists.infradead.org, Stephen Boyd , Takashi Iwai , linux-kernel@vger.kernel.org, Vinod Koul , Chancel Liu , dmaengine@vger.kernel.org, Krzysztof Kozlowski , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi Andi, On Fri, Jun 21, 2024 at 12:57=E2=80=AFAM Andi Shyti = wrote: > On Thu, Jun 20, 2024 at 07:56:41PM GMT, Piotr Wojtaszczyk wrote: > > When del_timer_sync() is called in an interrupt context it throws a war= ning > > because of potential deadlock. Threaded irq handler fixes the potential > > problem. > > > > Signed-off-by: Piotr Wojtaszczyk > > did you run into a lockdep splat? > > Anything against using del_timer(), instead? Have you tried? I didn't get a lockdep splat but console was flooded with warnings from https://github.com/torvalds/linux/blob/v6.10-rc4/kernel/time/timer.c#L1655 In the linux kernel v5.15 I didn't see these warnings. I'm not a maintainer of the driver and I didn't do any research on what kind of impact would have using del_timer() instad. Maybe Vladimir Zapolskiy will know tha= t. --=20 Piotr Wojtaszczyk Timesys