From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7CDA8C77B73 for ; Wed, 24 May 2023 17:33:50 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4QRJFS4VVPz3fN0 for ; Thu, 25 May 2023 03:33:48 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=209.85.218.47; helo=mail-ej1-f47.google.com; envelope-from=rjwysocki@gmail.com; receiver=) Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4QRJDx73DLz3c9x for ; Thu, 25 May 2023 03:33:21 +1000 (AEST) Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-96f66fbd770so35032766b.1 for ; Wed, 24 May 2023 10:33:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684949597; x=1687541597; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LCSKoj+QaYMGiALxKIVygFGEfEGQMG7Gw+jdrUBXjYI=; b=JOu9NuybKq7BqQRW5gZq838R9J+Ox6evveqCC2cHbVRWTbaJNGY3+ePa6Dl4Ppbksd eXQanaxgbI80LkgDXfINQNAKBNah8vs46azzJpMM8c+r4VXBNEkneq62ZijLiY00Qi9L rlPpFqt8MxDrDrIAdyMZadIDqtbRD2Shg48utkW6BY34CxNjuHaTdBSZKXdqOXo+qzlG A75iiVrXDTZ+nyN9weDk3Af81+DGLu5587BKMkntRJydmCMFne8l1E+e959190PI79Ug Lyrwug+K3rvryLq6Rr+3S8sZd3Jafk/QXTAdpVwqvRI8xxxOGs5aZ+Fo0+RfDMpUuJoi trvw== X-Gm-Message-State: AC+VfDyrig7M93mkamysOhh9ZIq8+GSd6TC5VPXzU9MrgDzfnvT2VMrJ tkrT0OmaDEobHPIeX65fmhj0fP+F790J1ANvquQ= X-Google-Smtp-Source: ACHHUZ75t5LOoP5fPEw1B3B8AOZ5QAW3p/uA3PR3RjFQ63NrJQ3bU0l+qjgSiV2WQ1zsptMKJ1KiCOsk0UIwyQ0utjI= X-Received: by 2002:a17:906:2218:b0:96f:4c38:4b1a with SMTP id s24-20020a170906221800b0096f4c384b1amr16403004ejs.5.1684949596574; Wed, 24 May 2023 10:33:16 -0700 (PDT) MIME-Version: 1.0 References: <20230517131102.934196-1-arnd@kernel.org> <20230517131102.934196-11-arnd@kernel.org> <6b7f6f66-7890-47a3-a22d-e29f2944823a@app.fastmail.com> In-Reply-To: <6b7f6f66-7890-47a3-a22d-e29f2944823a@app.fastmail.com> From: "Rafael J. Wysocki" Date: Wed, 24 May 2023 19:33:05 +0200 Message-ID: Subject: Re: [PATCH 10/14] suspend: add a arch_resume_nosmt() prototype To: Arnd Bergmann Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kselftest@vger.kernel.org, "Rafael J . Wysocki" , Peter Zijlstra , Catalin Marinas , linux-mips@vger.kernel.org, linux-mm@kvack.org, Pavel Machek , Christoph Lameter , Will Deacon , linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, Paul Moore , linux-sh@vger.kernel.org, Helge Deller , x86@kernel.org, Russell King , Ingo Molnar , Dennis Zhou , Boqun Feng , linux-pm@vger.kernel.org, Heiko Carstens , Waiman Long , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, kunit-dev@googlegroups.com, Arnd Bergmann , Michal Simek , Thomas Bogendoerfer , linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org, Eric Paris , audit@vger.kernel.org, Palmer Dabbelt , Tejun Heo , Andrew Morton , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, May 17, 2023 at 4:52=E2=80=AFPM Arnd Bergmann wrote= : > > On Wed, May 17, 2023, at 15:48, Rafael J. Wysocki wrote: > > On Wed, May 17, 2023 at 3:12=E2=80=AFPM Arnd Bergmann = wrote: > >> > >> From: Arnd Bergmann > >> > >> The arch_resume_nosmt() has a __weak definition, plus an x86 > >> specific override, but no prototype that ensures the two have > >> the same arguments. This causes a W=3D1 warning: > >> > >> arch/x86/power/hibernate.c:189:5: error: no previous prototype for 'ar= ch_resume_nosmt' [-Werror=3Dmissing-prototypes] > >> > >> Add the prototype in linux/suspend.h, which is included in > >> both places. > >> > >> Signed-off-by: Arnd Bergmann > > > > Do you want me to pick this up? > > Yes, please do. Thanks, Done, thanks!