From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A23AFCA0FFC for ; Sat, 2 Sep 2023 06:19:10 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=hIUKwpwm; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Rd4VP18PKz3c8c for ; Sat, 2 Sep 2023 16:19:09 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=hIUKwpwm; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=139.178.84.217; helo=dfw.source.kernel.org; envelope-from=masahiroy@kernel.org; receiver=lists.ozlabs.org) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Rd4TR1gPJz2yh4 for ; Sat, 2 Sep 2023 16:18:19 +1000 (AEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A63FD61681 for ; Sat, 2 Sep 2023 06:18:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 08789C433CA for ; Sat, 2 Sep 2023 06:18:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693635495; bh=S2JjhDQaQjCUBS5BoHwvNrpSReY7nD+6fFAceggH5L4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=hIUKwpwmhpYMtn3fTmQXOATMfWHK5+QPj14H0A97QXLXMppSSF9eVXCHQIGuGPsDY JjzSpA3VOzM9M2jNUI1NrIRu8zgcBXHLxoQM6oHLaopiRUU3znUlfC12Ro9UhBiyLx uQT/EorLWHbocPK7E0C1R7T0Ceo4xuq7MBqd0VBTtdv+WbnaPLX7CNg9/sp8uC4d1q E6nGabVyu+eSwVBRG+WRXgYyuhhV+6YVwCc4NAO2vfjaKe5QtdE0vr3jDD9pYrofL/ ZGRbk7ZUIJXJ2i3EKLtq2t4f9yRJMYPM7drBRGh6gbPpID1D4FJKbE/iBAkuyvuhrL efRJeyXUxdCfw== Received: by mail-oa1-f47.google.com with SMTP id 586e51a60fabf-1c8d895a602so1722659fac.2 for ; Fri, 01 Sep 2023 23:18:14 -0700 (PDT) X-Gm-Message-State: AOJu0YzvT4EIN9ffCblrvL/+dHZWS2Feu2Tm/lvxdjQ9pL6QYA/SqKGn MgAvgDnYj18tGbUNxymlyEwXvjxTG4ETPqiobHA= X-Google-Smtp-Source: AGHT+IESGICPQ/WBafsIpCkqlmLOntDrnFZ4mcqJsB8bb0Bsgx61YqGasOzlsnoQknaLtIFXHXJ++FKkRqersGaIAOU= X-Received: by 2002:a05:6870:ac12:b0:1b7:3f07:e431 with SMTP id kw18-20020a056870ac1200b001b73f07e431mr5406945oab.54.1693635494264; Fri, 01 Sep 2023 23:18:14 -0700 (PDT) MIME-Version: 1.0 References: <20230831191335.give.534-kees@kernel.org> <202309011250.AB0DAA03@keescook> In-Reply-To: <202309011250.AB0DAA03@keescook> From: Masahiro Yamada Date: Sat, 2 Sep 2023 15:17:37 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3] kbuild: Show marked Kconfig fragments in "help" To: Kees Cook Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-s390@vger.kernel.org, Randy Dunlap , Nicolas Schier , linux-kbuild@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Sat, Sep 2, 2023 at 4:50=E2=80=AFAM Kees Cook wr= ote: > > On Fri, Sep 01, 2023 at 04:58:37PM +0900, Masahiro Yamada wrote: > > On Fri, Sep 1, 2023 at 4:13=E2=80=AFAM Kees Cook wrote: > > > > > > Currently the Kconfig fragments in kernel/configs and arch/*/configs > > > that aren't used internally aren't discoverable through "make help", > > > which consists of hard-coded lists of config fragments. Instead, list > > > all the fragment targets that have a "# Help: " comment prefix so the > > > targets can be generated dynamically. > > > > > > Add logic to the Makefile to search for and display the fragment and > > > comment. Add comments to fragments that are intended to be direct tar= gets. > > > > > > Cc: Nicolas Schier > > > Cc: Michael Ellerman > > > Cc: Christophe Leroy > > > Cc: Randy Dunlap > > > Cc: linux-kernel@vger.kernel.org > > > Cc: x86@kernel.org > > > Cc: linux-arm-kernel@lists.infradead.org > > > Cc: linuxppc-dev@lists.ozlabs.org > > > Cc: linux-riscv@lists.infradead.org > > > Cc: linux-s390@vger.kernel.org > > > Cc: linux-kbuild@vger.kernel.org > > > Cc: linux-hardening@vger.kernel.org > > > Signed-off-by: Kees Cook > > > Co-developed-by: Masahiro Yamada > > > --- > > > v3: > > > - Use Makefile logic from Masahiro Yamada > > > - Use "# Help: " prefix, but only on desired fragment targets > > > v2: https://lore.kernel.org/all/20230825194329.gonna.911-kees@kernel.= org > > > v1: https://lore.kernel.org/all/20230824223606.never.762-kees@kernel.= org > > > --- > > > Makefile | 1 - > > > arch/arm/configs/dram_0x00000000.config | 1 + > > > arch/arm/configs/dram_0xc0000000.config | 1 + > > > arch/arm/configs/dram_0xd0000000.config | 1 + > > > arch/arm/configs/lpae.config | 1 + > > > arch/arm64/configs/virt.config | 1 + > > > arch/powerpc/configs/disable-werror.config | 1 + > > > arch/powerpc/configs/security.config | 4 +++- > > > arch/riscv/configs/32-bit.config | 1 + > > > arch/riscv/configs/64-bit.config | 1 + > > > arch/s390/configs/btf.config | 1 + > > > arch/s390/configs/kasan.config | 1 + > > > arch/x86/Makefile | 4 ---- > > > kernel/configs/debug.config | 2 ++ > > > kernel/configs/kvm_guest.config | 1 + > > > kernel/configs/nopm.config | 2 ++ > > > kernel/configs/rust.config | 1 + > > > kernel/configs/tiny.config | 2 ++ > > > kernel/configs/x86_debug.config | 1 + > > > kernel/configs/xen.config | 2 ++ > > > scripts/kconfig/Makefile | 15 ++++++++++++--- > > > 21 files changed, 36 insertions(+), 9 deletions(-) > > > > > > > > > Just one thing. > > > > > > > > > > > > > diff --git a/kernel/configs/tiny.config b/kernel/configs/tiny.config > > > index 00009f7d0835..60a4b6d80b36 100644 > > > --- a/kernel/configs/tiny.config > > > +++ b/kernel/configs/tiny.config > > > @@ -1,3 +1,5 @@ > > > +# Help: Size-optimized kernel image > > > > > > I will drop this. > > > > > > We already have a hard-coded help message. > > > > tinyconfig - Configure the tiniest possible kernel > > > > > > > > > > Then, some lines below, again. > > > > tiny.config - Size-optimized kernel image > > > > > > > > tiny.config is for internal use for tinyconfig. > > Shall I send a v4, or did you fix this up already? Locally fixed-up. If nobody points out anything else, you do not need to send v4. --=20 Best Regards Masahiro Yamada