From: Masahiro Yamada <masahiroy@kernel.org>
To: Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
"Aneesh Kumar K . V" <aneesh.kumar@kernel.org>,
"Naveen N . Rao" <naveen.n.rao@linux.ibm.com>,
linuxppc-dev@lists.ozlabs.org, Daniel Axtens <dja@axtens.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc: remove unused *_syscall_64.o variables in Makefile
Date: Sat, 17 Feb 2024 10:06:56 +0900 [thread overview]
Message-ID: <CAK7LNARFNoAUUiGMP95pTi_rSxSi5Z0HJo2kBC472f0koMr2mA@mail.gmail.com> (raw)
In-Reply-To: <20240216135517.2002749-1-masahiroy@kernel.org>
+To: Daniel Axtens
Maybe, we should check if the issue fixed by
2f26ed1764b42a8c40d9c48441c73a70d805decf
came back.
On Fri, Feb 16, 2024 at 10:55 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> Commit ab1a517d55b0 ("powerpc/syscall: Rename syscall_64.c into
> interrupt.c") missed to update these three lines:
>
> GCOV_PROFILE_syscall_64.o := n
> KCOV_INSTRUMENT_syscall_64.o := n
> UBSAN_SANITIZE_syscall_64.o := n
>
> To restore the original behavior, we could replace them with:
>
> GCOV_PROFILE_interrupt.o := n
> KCOV_INSTRUMENT_interrupt.o := n
> UBSAN_SANITIZE_interrupt.o := n
>
> However, nobody has noticed the functional change in the past three
> years, so they were unneeded.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
> arch/powerpc/kernel/Makefile | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/powerpc/kernel/Makefile b/arch/powerpc/kernel/Makefile
> index 2919433be355..72d1cd6443bc 100644
> --- a/arch/powerpc/kernel/Makefile
> +++ b/arch/powerpc/kernel/Makefile
> @@ -191,9 +191,6 @@ GCOV_PROFILE_kprobes-ftrace.o := n
> KCOV_INSTRUMENT_kprobes-ftrace.o := n
> KCSAN_SANITIZE_kprobes-ftrace.o := n
> UBSAN_SANITIZE_kprobes-ftrace.o := n
> -GCOV_PROFILE_syscall_64.o := n
> -KCOV_INSTRUMENT_syscall_64.o := n
> -UBSAN_SANITIZE_syscall_64.o := n
> UBSAN_SANITIZE_vdso.o := n
>
> # Necessary for booting with kcov enabled on book3e machines
> --
> 2.40.1
>
--
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2024-02-17 1:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-16 13:55 [PATCH] powerpc: remove unused *_syscall_64.o variables in Makefile Masahiro Yamada
2024-02-17 1:06 ` Masahiro Yamada [this message]
2024-02-20 5:43 ` Michael Ellerman
2024-05-08 13:39 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK7LNARFNoAUUiGMP95pTi_rSxSi5Z0HJo2kBC472f0koMr2mA@mail.gmail.com \
--to=masahiroy@kernel.org \
--cc=aneesh.kumar@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=dja@axtens.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=naveen.n.rao@linux.ibm.com \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).