From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5D27DC433EF for ; Thu, 20 Jan 2022 09:30:21 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4JfcgH696Cz3cDS for ; Thu, 20 Jan 2022 20:30:19 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=arndb.de (client-ip=212.227.126.187; helo=mout.kundenserver.de; envelope-from=arnd@arndb.de; receiver=) Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.187]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Jfcfq4bpkz2ywd for ; Thu, 20 Jan 2022 20:29:55 +1100 (AEDT) Received: from mail-ot1-f51.google.com ([209.85.210.51]) by mrelayeu.kundenserver.de (mreue010 [213.165.67.97]) with ESMTPSA (Nemesis) id 1Mv3Ds-1mJt8x2awq-00qwq0 for ; Thu, 20 Jan 2022 10:29:51 +0100 Received: by mail-ot1-f51.google.com with SMTP id a12-20020a0568301dcc00b005919e149b4cso6778595otj.8 for ; Thu, 20 Jan 2022 01:29:51 -0800 (PST) X-Gm-Message-State: AOAM533JGuARfBETeA6axk00fgwvX9ATU+EKlTbYUfz9gcdtX9nCeqZ2 +cHaPgZW/bNdrYNZE8JEBlo8HNdcatSstql9bMI= X-Google-Smtp-Source: ABdhPJw23cQjee+wzKe1BZuP5Egl38StW0xVS2Lx2CrxQkm8C96LIXXcbD+ld7BJcIRLzViPyYDZ1TVXzpuf+zNTwjI= X-Received: by 2002:a05:6830:2095:: with SMTP id y21mr25066257otq.368.1642670990087; Thu, 20 Jan 2022 01:29:50 -0800 (PST) MIME-Version: 1.0 References: <20220120073911.99857-7-guoren@kernel.org> In-Reply-To: <20220120073911.99857-7-guoren@kernel.org> From: Arnd Bergmann Date: Thu, 20 Jan 2022 10:29:33 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH V3 06/17] riscv: compat: Add basic compat date type implementation To: Guo Ren Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:KKX+9HNtA1mSU6MqbV/jXbUwxpLtyTxOis6xqiY8Iql1Mw2tmed 4pQ2xse4Ke0qy+egGetawqI6y4OVjCGUu9BZvpumkZ5gYr/i/p8rf74VcfTmk7NrPBE4m3J Eoj66qlekUKAD8zjGaPT/iEODJYnZ/Ex8gcj9dDfIUytEaepW31oMVbIKsbLGq7VXy57C/I RmlvKbDAfHtz3/1jJtxRQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:XO1LaekllgM=:kE35Gc0ZktCHbAM4CE1qM5 CRZuxP+I4Zqebk1rr9G1iquL6eyMKFlGEf5//bsnLfIRprtY+kPJLJe/4yw5xqA/B7Czri1Um USXVfye4b+o6/OPdVDjWuTsZGRwSM7nf6P3ZuY141k13omSm3+c61szu1AfcervMg+I53wTSy MxsGI2X6HPgxACtmize0AYewCuyrR9UYM/p278eiPoGQGcDvhxFYMZ7u7wL5EDmMP5IA2OKPc oL+l5bBNuOHnXbV5S6uskFvwytHEVg8PRPOY2ffoaNoivy8vJJVW2TMECHKWjkA9nTIbUtybX Wav6pcu0V3qneAyDj5eS2KnZmK7oZ4HDC9mrAiiFKyoRq753HQhVmhIITtU3KM+/pjD51w/2G C4SZWND/Wp4LuhuOqSuwpDpPbDDTGh+Mqzx3K9IWPNOncEBmq5iSB0zv7NvQMI1IiAK97KLHd zOU0oWRxxipET1T0HZ0vXaaJxSJRya7jzwefNfw54tOGFWzrcg1DKgoXN6JDRepsMICiLehsW DE4Z/IbicoCMj/UHiNhrE62XXhbGPas8aYjUH5C+AT/UcTmXm0CfYhzA6jfi5wiK14BhMtRF5 yMD0bCg+6lhN+tjuuwMMZGSbknWnEacWGV/IYt136Fo3LXiAJL/kholpCV4PM6pTQlIbgCbMn jju0GrlJ+8z0xaEIErpY6XNejIR3jjrf7fnClW4yc9gPaP5Pn4o3ao9fsf+aHO760n/2GpWnS BIke5XSgco5kIRBYyQAHu35cFcaGlm+w6FztaN+VtPD6nF7WYARFdJZG5jJ61RehaH0nftBKO Tz2emAC8tXwt2c98kiemdRY0E4aUaEhbHtfA3tSiWTLatNz09s= X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-s390 , Guo Ren , Arnd Bergmann , gregkh , Drew Fustini , Anup Patel , Wang Junqiang , the arch/x86 maintainers , Linux Kernel Mailing List , linux-csky@vger.kernel.org, inux-parisc@vger.kernel.org, Christoph Hellwig , Palmer Dabbelt , liush , sparclinux , linux-riscv , "open list:BROADCOM NVRAM DRIVER" , linuxppc-dev , Christoph Hellwig , Linux ARM , Wei Fu Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, Jan 20, 2022 at 8:38 AM wrote: > @@ -0,0 +1,136 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +#ifndef __ASM_COMPAT_H > +#define __ASM_COMPAT_H > + > +#define compat_mode_t compat_mode_t > +typedef u16 compat_mode_t; I think this one is wrong, as rv32 should get the native definition from include/uapi/asm-generic/posix_types.h:typedef unsigned int __kernel_mode_t; I think it works if you just remove those two lines. The rest looks good to me. Arnd