linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: "Pali Rohár" <pali@kernel.org>
Cc: Michael Ellerman <michael@ellerman.id.au>,
	linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] powerpc: e500: Fix compilation with gcc e500 compiler
Date: Fri, 8 Jul 2022 22:06:46 +0200	[thread overview]
Message-ID: <CAK8P3a0qzes1rXJDKF_6j0-KeB5V4M7ZMeHRrNk-KOQwA0vVEw@mail.gmail.com> (raw)
In-Reply-To: <20220708171422.mpbhb4ejarwnce6m@pali>

On Fri, Jul 8, 2022 at 7:14 PM Pali Rohár <pali@kernel.org> wrote:
>
> -ifeq ($(HAS_BIARCH),y)
> -ifeq ($(CROSS32_COMPILE),)
> -ifdef CONFIG_PPC32
> -# These options will be overridden by any -mcpu option that the CPU
> -# or platform code sets later on the command line, but they are needed
> -# to set a sane 32-bit cpu target for the 64-bit cross compiler which
> -# may default to the wrong ISA.
> -KBUILD_CFLAGS          += -mcpu=powerpc
> -KBUILD_AFLAGS          += -mcpu=powerpc
> -endif
> -endif

I think to remove these, we first need to ensure that /some/ option is
set for any of
the CPU options.
>
> -ifdef CONFIG_PPC32
> -ifdef CONFIG_PPC_E500MC
> -CFLAGS-y += $(call cc-option,-mcpu=e500mc,-mcpu=powerpc)
> -else
> +CFLAGS-$(CONFIG_PPC_E500MC) += $(call cc-option,-mcpu=e500mc,-mcpu=powerpc)
>  CFLAGS-$(CONFIG_E500) += $(call cc-option,-mcpu=8540 -msoft-float,-mcpu=powerpc)
> -endif
> -endif
>

And this part will not do what you want because CONFIG_PPC_E500MC is only
set when CONFIG_E500 is also set, so the -mcpu=e500mc option always
gets overridden by -mcpu=8540

         Arnd

  reply	other threads:[~2022-07-08 20:07 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-24  9:39 [PATCH] powerpc: e500: Fix compilation with gcc e500 compiler Pali Rohár
2022-05-24 17:59 ` Segher Boessenkool
2022-05-24 18:12   ` Pali Rohár
2022-05-24 18:52     ` Segher Boessenkool
2022-05-24 19:16       ` Pali Rohár
2022-05-24 19:52         ` Segher Boessenkool
2022-07-02  9:39           ` Pali Rohár
2022-07-02  9:44 ` Pali Rohár
2022-07-04 10:23   ` Michael Ellerman
2022-07-04 10:39     ` Pali Rohár
2022-07-04 12:07       ` Arnd Bergmann
2022-07-04 13:13         ` Pali Rohár
2022-07-04 13:22           ` Arnd Bergmann
2022-07-04 13:29             ` Pali Rohár
2022-07-04 13:43               ` Arnd Bergmann
2022-07-07  9:56                 ` Christophe Leroy
2022-07-07  9:59                   ` Pali Rohár
2022-07-08 17:14           ` Pali Rohár
2022-07-08 20:06             ` Arnd Bergmann [this message]
2022-07-09  9:16             ` Christophe Leroy
2022-07-09 10:23               ` Pali Rohár
2022-07-10 17:38                 ` Christophe Leroy
2022-07-10 17:57                   ` Pali Rohár
2022-07-11 14:20                     ` Christophe Leroy
2022-07-08 17:12         ` Pali Rohár
2022-07-08 20:04           ` Arnd Bergmann
2022-07-09  8:51             ` Christophe Leroy
2022-07-09  9:26             ` Christophe Leroy
2022-07-11 16:14               ` Segher Boessenkool
2022-07-11 17:32                 ` Christophe Leroy
2022-07-11 21:48                   ` Segher Boessenkool
2022-07-12  9:22                     ` Christophe Leroy
2022-07-12 14:11                       ` Segher Boessenkool

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAK8P3a0qzes1rXJDKF_6j0-KeB5V4M7ZMeHRrNk-KOQwA0vVEw@mail.gmail.com \
    --to=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=michael@ellerman.id.au \
    --cc=pali@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).