From: Arnd Bergmann <arnd@arndb.de>
To: "Benjamin Stürz" <benni@stuerz.xyz>
Cc: "Andrew Lunn" <andrew@lunn.ch>,
linux-atm-general@lists.sourceforge.net,
linux-ia64@vger.kernel.org,
"Linus Walleij" <linus.walleij@linaro.org>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
linux-pci <linux-pci@vger.kernel.org>,
"Robert Moore" <robert.moore@intel.com>,
"Harald Welte" <laforge@gnumonks.org>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
"H. Peter Anvin" <hpa@zytor.com>,
wcn36xx@lists.infradead.org, Pkshih <pkshih@realtek.com>,
"moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES"
<linux-samsung-soc@vger.kernel.org>,
"ACPI Devel Maling List" <linux-acpi@vger.kernel.org>,
linux-edac@vger.kernel.org,
dennis.dalessandro@cornelisnetworks.com,
linux-rdma <linux-rdma@vger.kernel.org>,
"Gregory CLEMENT" <gregory.clement@bootlin.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
"Russell King - ARM Linux" <linux@armlinux.org.uk>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
"Ingo Molnar" <mingo@redhat.com>,
"Chas Williams" <3chas3@gmail.com>,
"open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
"Jakub Kicinski" <kuba@kernel.org>,
pabeni@redhat.com, "Len Brown" <lenb@kernel.org>,
mike.marciniszyn@cornelisnetworks.com,
"Robert Richter" <rric@kernel.org>,
"Andrew Donnellan" <ajd@linux.ibm.com>,
"Arnd Bergmann" <arnd@arndb.de>,
kvalo@kernel.org, linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
loic.poulain@linaro.org, "Borislav Petkov" <bp@alien8.de>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Linux Media Mailing List" <linux-media@vger.kernel.org>,
"Simtec Linux Team" <linux@simtec.co.uk>,
"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
"open list:ACPI COMPONENT ARCHITECTURE (ACPICA)"
<devel@acpica.org>, "Karsten Keil" <isdn@linux-pingi.de>,
"Tony Luck" <tony.luck@intel.com>,
"Nicolas Pitre" <nico@fluxnic.net>,
gregkh <gregkh@linuxfoundation.org>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"David Miller" <davem@davemloft.net>,
"James Morse" <james.morse@arm.com>,
Networking <netdev@vger.kernel.org>,
"Frederic Barrat" <fbarrat@linux.ibm.com>,
"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>,
"Pali Rohár" <pali@kernel.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>
Subject: Re: [PATCH 01/22] orion5x: Replace comments with C99 initializers
Date: Sat, 26 Mar 2022 20:23:31 +0100 [thread overview]
Message-ID: <CAK8P3a1e57mNUQgronhwrsXsuQW9sZYxCktKij7NwsieBWiGmw@mail.gmail.com> (raw)
In-Reply-To: <20220326165909.506926-1-benni@stuerz.xyz>
On Sat, Mar 26, 2022 at 5:58 PM Benjamin Stürz <benni@stuerz.xyz> wrote:
>
> This replaces comments with C99's designated
> initializers because the kernel supports them now.
The change looks fine, but the comment looks misplaced, as enum initializers
are not c99 feature. Also, the named array and struct intializers have been
supported by gnu89 for a long time and widely used in the kernel, so it's
not a recent change even for the others.
Also,
Arnd
next prev parent reply other threads:[~2022-03-27 2:05 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-26 16:58 [PATCH 01/22] orion5x: Replace comments with C99 initializers Benjamin Stürz
2022-03-26 16:58 ` [PATCH 02/22] s3c: " Benjamin Stürz
2022-03-26 19:44 ` Joe Perches
2022-03-28 13:37 ` Daniel Thompson
2022-03-26 16:58 ` [PATCH 03/22] ia64: " Benjamin Stürz
2022-03-26 16:58 ` [PATCH 04/22] x86: " Benjamin Stürz
2022-03-28 23:08 ` Thomas Gleixner
2022-03-26 16:58 ` [PATCH 05/22] acpica: " Benjamin Stürz
2022-03-27 19:59 ` Andy Shevchenko
2022-03-31 19:27 ` Moore, Robert
2022-04-01 5:09 ` Christoph Hellwig
2022-04-01 5:10 ` Christoph Hellwig
2022-03-28 12:33 ` Rafael J. Wysocki
2022-03-26 16:58 ` [PATCH 06/22] idt77252: " Benjamin Stürz
2022-03-26 16:58 ` [PATCH 07/22] cm4000: " Benjamin Stürz
2022-03-26 16:58 ` [PATCH 08/22] i5100: " Benjamin Stürz
2022-03-26 16:58 ` [PATCH 09/22] gpio-winbond: Use " Benjamin Stürz
2022-03-27 12:03 ` Linus Walleij
2022-03-29 12:30 ` Bartosz Golaszewski
2022-03-26 16:58 ` [PATCH 10/22] hfi1: Replace comments with " Benjamin Stürz
2022-03-26 16:58 ` [PATCH 11/22] rdmavt: " Benjamin Stürz
2022-03-27 7:04 ` Leon Romanovsky
2022-03-31 17:41 ` Dennis Dalessandro
2022-03-26 16:58 ` [PATCH 12/22] alps: " Benjamin Stürz
2022-03-26 16:59 ` [PATCH 13/22] capi: " Benjamin Stürz
2022-03-26 16:59 ` [PATCH 14/22] mISDN: " Benjamin Stürz
2022-03-26 16:59 ` [PATCH 15/22] macintosh: " Benjamin Stürz
2022-03-26 16:59 ` [PATCH 16/22] dvb-usb: " Benjamin Stürz
2022-03-26 18:24 ` Mauro Carvalho Chehab
2022-03-26 18:27 ` Mauro Carvalho Chehab
2022-03-26 19:51 ` Joe Perches
2022-03-26 20:11 ` Larry Finger
2022-03-26 21:08 ` Mauro Carvalho Chehab
2022-03-26 16:59 ` [PATCH 17/22] cxl: " Benjamin Stürz
2022-03-26 16:59 ` [PATCH 18/22] smsc: " Benjamin Stürz
2022-03-26 16:59 ` [PATCH 19/22] wnc36xx: " Benjamin Stürz
2022-03-28 16:17 ` Jeff Johnson
2022-03-26 16:59 ` [PATCH 20/22] wireless: " Benjamin Stürz
2022-03-28 12:06 ` Kalle Valo
2022-03-26 16:59 ` [PATCH 21/22] rtw89: " Benjamin Stürz
2022-03-26 18:55 ` Larry Finger
2022-03-28 9:28 ` Kalle Valo
2022-03-28 12:21 ` David Laight
2022-03-26 16:59 ` [PATCH 22/22] pci: " Benjamin Stürz
2022-03-26 18:20 ` [PATCH 01/22] orion5x: " Mauro Carvalho Chehab
2022-03-26 19:23 ` Arnd Bergmann [this message]
2022-03-28 13:19 ` Segher Boessenkool
2022-03-27 12:46 ` [PATCH 00/22] " Benjamin Stürz
2022-03-28 9:33 ` Kalle Valo
2022-03-28 11:51 ` Benjamin Stürz
2022-03-28 12:31 ` Kalle Valo
2022-03-28 20:20 ` Jakub Kicinski
2022-03-28 13:47 ` Daniel Thompson
2022-03-28 13:17 ` [PATCH 01/22] orion5x: " Daniel Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a1e57mNUQgronhwrsXsuQW9sZYxCktKij7NwsieBWiGmw@mail.gmail.com \
--to=arnd@arndb.de \
--cc=3chas3@gmail.com \
--cc=ajd@linux.ibm.com \
--cc=alim.akhtar@samsung.com \
--cc=andrew@lunn.ch \
--cc=benni@stuerz.xyz \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=brgl@bgdev.pl \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=dennis.dalessandro@cornelisnetworks.com \
--cc=devel@acpica.org \
--cc=dmitry.torokhov@gmail.com \
--cc=fbarrat@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=gregory.clement@bootlin.com \
--cc=hpa@zytor.com \
--cc=isdn@linux-pingi.de \
--cc=james.morse@arm.com \
--cc=jgg@ziepe.ca \
--cc=krzk@kernel.org \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=laforge@gnumonks.org \
--cc=lenb@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=linux-edac@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@simtec.co.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=loic.poulain@linaro.org \
--cc=mchehab@kernel.org \
--cc=mike.marciniszyn@cornelisnetworks.com \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nico@fluxnic.net \
--cc=pabeni@redhat.com \
--cc=pali@kernel.org \
--cc=pkshih@realtek.com \
--cc=rafael.j.wysocki@intel.com \
--cc=robert.moore@intel.com \
--cc=rric@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=wcn36xx@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).