From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-x241.google.com (mail-qk0-x241.google.com [IPv6:2607:f8b0:400d:c09::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 401kS82DXDzDrNC for ; Thu, 15 Mar 2018 07:52:24 +1100 (AEDT) Received: by mail-qk0-x241.google.com with SMTP id v124so5011266qkh.11 for ; Wed, 14 Mar 2018 13:52:24 -0700 (PDT) MIME-Version: 1.0 Sender: arndbergmann@gmail.com In-Reply-To: References: <20180312175307.11032-3-deepa.kernel@gmail.com> <201803132313.a4R8Y434%fengguang.wu@intel.com> From: Arnd Bergmann Date: Wed, 14 Mar 2018 21:52:21 +0100 Message-ID: Subject: Re: [Y2038] [PATCH v4 02/10] include: Move compat_timespec/ timeval to compat_time.h To: Deepa Dinamani Cc: kbuild test robot , Mark Rutland , "open list:RALINK MIPS ARCHITECTURE" , Peter Zijlstra , Benjamin Herrenschmidt , Heiko Carstens , Paul Mackerras , "H. Peter Anvin" , sparclinux , devel@driverdev.osuosl.org, linux-s390 , y2038 Mailman List , Michael Ellerman , Helge Deller , "the arch/x86 maintainers" , sebott@linux.vnet.ibm.com, "James E.J. Bottomley" , Christian Borntraeger , Ingo Molnar , oprofile-list@lists.sf.net, Catalin Marinas , Peter Oberparleiter , Robert Richter , Chris Metcalf , Will Deacon , Arnaldo Carvalho de Melo , Julian Wiedmann , John Stultz , Steven Rostedt , Thomas Gleixner , gerald.schaefer@de.ibm.com, Parisc List , Greg KH , cohuck@redhat.com, Linux Kernel Mailing List , Ralf Baechle , "David S. Miller" , Jan Hoeppner , kbuild-all@01.org, Stefan Haberland , Martin Schwidefsky , linuxppc-dev , Ursula Braun Content-Type: text/plain; charset="UTF-8" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Mar 14, 2018 at 4:50 AM, Deepa Dinamani wrote: > The file arch/arm64/kernel/process.c needs asm/compat.h also to be > included directly since this is included conditionally from > include/compat.h. This does seem to be typical of arm64 as I was not > completely able to get rid of asm/compat.h includes for arm64 in this > series. My plan is to have separate patches to get rid of asm/compat.h > includes for the architectures that are not straight forward to keep > this series simple. > I will fix this and update the series. > I ran across the same thing in two more files during randconfig testing on arm64 now, adding this fixup on top for the moment, but maybe there is a better way: commit 4f3e9e1211799a79b201a1af309a1ec3864147ec Author: Arnd Bergmann Date: Wed Mar 14 18:23:16 2018 +0100 arm64: fix perf_regs.c arch/arm64/kernel/perf_regs.c: In function 'perf_reg_abi': arch/arm64/kernel/perf_regs.c:50:6: error: implicit declaration of function 'is_compat_thread'; did you mean 'is_compat_task'? [-Werror=implicit-function-declaration] arch/arm64/kernel/hw_breakpoint.c: In function 'is_compat_bp': arch/arm64/kernel/hw_breakpoint.c:182:16: error: implicit declaration of function 'is_compat_thread'; did you mean 'is_compat_task'? [-Werror=implicit-function-declaration] Signed-off-by: Arnd Bergmann diff --git a/arch/arm64/kernel/hw_breakpoint.c b/arch/arm64/kernel/hw_breakpoint.c index 413dbe530da8..74bb56f656ef 100644 --- a/arch/arm64/kernel/hw_breakpoint.c +++ b/arch/arm64/kernel/hw_breakpoint.c @@ -30,6 +30,7 @@ #include #include +#include #include #include #include diff --git a/arch/arm64/kernel/perf_regs.c b/arch/arm64/kernel/perf_regs.c index 0bbac612146e..1b463a4efe49 100644 --- a/arch/arm64/kernel/perf_regs.c +++ b/arch/arm64/kernel/perf_regs.c @@ -6,6 +6,7 @@ #include #include +#include #include #include