From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C15C7C04EBF for ; Tue, 4 Dec 2018 21:19:34 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1D0032082B for ; Tue, 4 Dec 2018 21:19:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1D0032082B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 438ZW72gGlzDqWs for ; Wed, 5 Dec 2018 08:19:31 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gmail.com (client-ip=209.85.222.194; helo=mail-qk1-f194.google.com; envelope-from=arndbergmann@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=arndb.de Received: from mail-qk1-f194.google.com (mail-qk1-f194.google.com [209.85.222.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 438ZSw6J6tzDqFh for ; Wed, 5 Dec 2018 08:17:36 +1100 (AEDT) Received: by mail-qk1-f194.google.com with SMTP id y78so10575658qka.12 for ; Tue, 04 Dec 2018 13:17:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oNLZdxPA/1JMTOenX3BXjqrafMgfKLzwoze6zSjaYjs=; b=SfOW6TFXf0gXeWG2ILl6xPltpwFIli7Mjk1doUL2MTD7pCGxzUwodfXb1xpjRwborP FykFbmtcBHausFpeoPKscNxkqz4VyGh1Lv8K4BCOnWG/hQ7p3F/9X1NbFa03tGymKvoV VS5OHiJJ2+/BVjnSr8mYy9OsV1s2hAhfNkaJP10DWMenZze9ROv2QeHTmYSI7bTyfdGE OuEcIJwoje28E7+f3qQeZu2g7LKc8GbAnTn70NEaJePe/+/DKUbuP8N/hiUM/bScY252 o6QZlOcNQ5zlIkkY13Yz38W/3atE3WyFAwsoIPbSWfw/fU4cNjDWbb89k/alpt0iseCl Am+w== X-Gm-Message-State: AA+aEWYZTiNUZ2s0cuR/R6MxYK5xorlbPXgz+0AHBI+y4jVCnXNYL5e4 X3u8EOIOxAvrxw3tIgrafEzC81KuBZVwFVFL8Z8= X-Google-Smtp-Source: AFSGD/WLqefm4/JZ8Oq0jJRXrV707I2FqcC+iotSpp9LY7+wMEyltpzSAqKwkIOad/jvr90tsqLqlJgfrLETvle9J5g= X-Received: by 2002:ae9:e102:: with SMTP id g2mr19045176qkm.343.1543958254395; Tue, 04 Dec 2018 13:17:34 -0800 (PST) MIME-Version: 1.0 References: <1543465611-17122-1-git-send-email-firoz.khan@linaro.org> <1543465611-17122-5-git-send-email-firoz.khan@linaro.org> In-Reply-To: <1543465611-17122-5-git-send-email-firoz.khan@linaro.org> From: Arnd Bergmann Date: Tue, 4 Dec 2018 22:17:18 +0100 Message-ID: Subject: Re: [PATCH v3 4/4] powerpc: generate uapi header and system call table files To: Firoz Khan Content-Type: text/plain; charset="UTF-8" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kate Stewart , linux-arch , gregkh , y2038 Mailman List , Boqun Feng , Philippe Ombredanne , linuxram@us.ibm.com, Linux Kernel Mailing List , Marcin Juszkiewicz , leitao@debian.org, Geert Uytterhoeven , Deepa Dinamani , Mathieu Desnoyers , Paul Mackerras , Thomas Gleixner , linuxppc-dev Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" > diff --git a/arch/powerpc/kernel/systbl.S b/arch/powerpc/kernel/systbl.S > index 9ff1913..d756348 100644 > --- a/arch/powerpc/kernel/systbl.S > +++ b/arch/powerpc/kernel/systbl.S > #ifdef CONFIG_PPC64 > @@ -47,5 +25,17 @@ > .globl sys_call_table > sys_call_table: > > +#if defined CONFIG_PPC64 && defined(CONFIG_COMPAT) > +#define __SYSCALL(nr, entry, nargs) .8byte entry > #define compat_sys_sigsuspend sys_sigsuspend > -#include > +#include > +#undef __SYSCALL > +#elif defined CONFIG_PPC64 && !defined(CONFIG_COMPAT) > +#define __SYSCALL(nr, entry, nargs) .8byte entry > +#include > +#undef __SYSCALL This part looks wrong: where the old sys_call_table contained both the native and compat calls side by side, the new table contains only the compat versions (note that CONFIG_COMPAT is always set on PPC64). I think you copy-pasted this incorrectly from one of the other architectures that uses a different layout for the compat calls. The way I think this could work best is if you add a preparation patch that splits out the 64-bit table into two separate ones (and make sure that works). After that, you can add your existing patch, rebased to use the two generated tables instead of the old-style tables. I'll follow up with an untested patch for illustration. Arnd