From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CF4A2C433EF for ; Thu, 24 Feb 2022 08:22:13 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4K45VW624sz2yQK for ; Thu, 24 Feb 2022 19:22:11 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=Jy10bEhk; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=2604:1380:4641:c500::1; helo=dfw.source.kernel.org; envelope-from=arnd@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=Jy10bEhk; dkim-atps=neutral Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4K45Tr2LDpz2x9b for ; Thu, 24 Feb 2022 19:21:36 +1100 (AEDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A03416197E for ; Thu, 24 Feb 2022 07:06:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 158FBC340F9 for ; Thu, 24 Feb 2022 07:06:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645686377; bh=d3iTCnmjiWI2WfX8T3i0lRHp9N81t6Yh8Z7V7FwGN/U=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Jy10bEhkuvKutCIGFpDkZC+Hy89lZrL0+AEM8JCCN1qUmDOdBzwiVytFWi8xi30gm 8ayvdRxl6CNK6aCjWaryDbV2bBGogimBAGkD4I17JgVRyZnOAc/lUBnG0eR5aODtwA rtxMI2na0WYPxyZvZxxanuNZCUJBptiFtg7gKn29ogWwD7b6oC/JnsXGY4E5WBaw2q ANdBA0kr7AJqPOVmyDBHVWy7mZ8xaz+mVTGb2WsAVdnc4LTPLlbryOwqc3rdsDnwQN JZYhQyjwewRqtADxsqZiJvrUAX/Ledd/9wNLxlL5HvN3vaEaRc8iEbsF5iECkSqQL+ Hi7YE7Duy7Y2g== Received: by mail-wr1-f51.google.com with SMTP id x15so1451447wrg.8 for ; Wed, 23 Feb 2022 23:06:16 -0800 (PST) X-Gm-Message-State: AOAM532lsPA/9ehBiAJObQgd2Vqz97qlEPN3tmzS1BRY7bPRLlIGGK8l bo4GmTSaZEXcSu/VRn8HRPI9LDqnfxtPnpzEN0s= X-Google-Smtp-Source: ABdhPJyN7vOmEPkorPTffJc1X7o++TFchfjh5Aum2nyP+tyYB62T97KqiFOhsVfqhaexAyBFN29agtP9qBPfezDsID0= X-Received: by 2002:adf:a446:0:b0:1ed:c41b:cf13 with SMTP id e6-20020adfa446000000b001edc41bcf13mr1075883wra.407.1645686364180; Wed, 23 Feb 2022 23:06:04 -0800 (PST) MIME-Version: 1.0 References: <20220216131332.1489939-1-arnd@kernel.org> <20220216131332.1489939-8-arnd@kernel.org> In-Reply-To: From: Arnd Bergmann Date: Thu, 24 Feb 2022 08:05:48 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 07/18] nios2: drop access_ok() check from __put_user() To: Dinh Nguyen Content-Type: text/plain; charset="UTF-8" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Rich Felker , linux-ia64@vger.kernel.org, Linux-sh list , Peter Zijlstra , "open list:BROADCOM NVRAM DRIVER" , Linux-MM , Guo Ren , sparclinux , "open list:QUALCOMM HEXAGON..." , linux-riscv , Will Deacon , Christoph Hellwig , linux-arch , linux-s390 , Brian Cain , Helge Deller , the arch/x86 maintainers , Russell King - ARM Linux , linux-csky@vger.kernel.org, Ard Biesheuvel , Ingo Molnar , Geert Uytterhoeven , "open list:SYNOPSYS ARC ARCHITECTURE" , "open list:TENSILICA XTENSA PORT \(xtensa\)" , Arnd Bergmann , Heiko Carstens , alpha , linux-um , linuxppc-dev , linux-m68k , Openrisc , Al Viro , Stafford Horne , Michal Simek , Thomas Bogendoerfer , Parisc List , Nick Hu , Max Filippov , Linux API , Linux Kernel Mailing List , "Eric W . Biederman" , Richard Weinberger , Andrew Morton , Linus Torvalds , David Miller , Greentime Hu Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, Feb 24, 2022 at 12:30 AM Dinh Nguyen wrote: > On 2/16/22 07:13, Arnd Bergmann wrote: From: Arnd Bergmann > > > > Unlike other architectures, the nios2 version of __put_user() has an > > extra check for access_ok(), preventing it from being used to implement > > __put_kernel_nofault(). > > > > Split up put_user() along the same lines as __get_user()/get_user() > > > > Signed-off-by: Arnd Bergmann > > Acked-by: Dinh Nguyen Thanks! Could you also have a look at patch 2 (uaccess: fix nios2 and microblaze get_user_8)? That one is actually more critical, and should be backported to stable kernels. Arnd