From: Arnd Bergmann <arnd@arndb.de>
To: Jakub Kicinski <kuba@kernel.org>
Cc: tsbogend@alpha.franken.de, linux-parisc@vger.kernel.org,
arnd@arndb.de, corbet@lwn.net, netdev@vger.kernel.org,
sburla@marvell.com, linux-doc@vger.kernel.org,
linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
edumazet@google.com, paulus@samba.org, vburru@marvell.com,
zhangyue1@kylinos.cn, pabeni@redhat.com, aayarekar@marvell.com,
davem@davemloft.net
Subject: Re: [PATCH net-next] eth: de4x5: remove support for Generic DECchip & DIGITAL EtherWORKS PCI/EISA
Date: Fri, 20 May 2022 13:30:50 +0100 [thread overview]
Message-ID: <CAK8P3a3_4fNQV51V0-QUnuTr4dK0-S_ffeFzfA8vG1uGh8vyhg@mail.gmail.com> (raw)
In-Reply-To: <20220519031345.2134401-1-kuba@kernel.org>
On Thu, May 19, 2022 at 4:13 AM Jakub Kicinski <kuba@kernel.org> wrote:
>
> Looks like almost all changes to this driver had been tree-wide
> refactoring since git era begun. There is one commit from Al
> 15 years ago which could potentially be fixing a real bug.
>
> The driver is using virt_to_bus() and is a real magnet for pointless
> cleanups. It seems unlikely to have real users. Let's try to shed
> this maintenance burden.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: corbet@lwn.net
> CC: tsbogend@alpha.franken.de
> CC: mpe@ellerman.id.au
> CC: benh@kernel.crashing.org
> CC: paulus@samba.org
> CC: sburla@marvell.com
> CC: vburru@marvell.com
> CC: aayarekar@marvell.com
> CC: arnd@arndb.de
Acked-by: Arnd Bergmann <arnd@arndb.de>
> ---
> .../device_drivers/ethernet/dec/de4x5.rst | 189 -
> .../device_drivers/ethernet/index.rst | 1 -
> arch/mips/configs/mtx1_defconfig | 1 -
> arch/powerpc/configs/chrp32_defconfig | 1 -
> arch/powerpc/configs/ppc6xx_defconfig | 1 -
> drivers/net/ethernet/dec/tulip/Kconfig | 15 -
> drivers/net/ethernet/dec/tulip/Makefile | 1 -
> drivers/net/ethernet/dec/tulip/de4x5.c | 5591 -----------------
> drivers/net/ethernet/dec/tulip/de4x5.h | 1017 ---
I checked the defconfig files to make sure we are not removing the
last ethernet driver from
one of them. mtx1 has built-in networking and no PCI slot, so this is
definitely fine.
the ppc32 configs are for machines with PCI slots and also enable
multiple drivers but I saw
nothing specifically needing this card.
Arnd
next prev parent reply other threads:[~2022-05-20 12:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 3:13 [PATCH net-next] eth: de4x5: remove support for Generic DECchip & DIGITAL EtherWORKS PCI/EISA Jakub Kicinski
2022-05-20 10:40 ` Michael Ellerman
2022-05-20 12:30 ` Arnd Bergmann [this message]
2022-05-21 2:47 ` Benjamin Herrenschmidt
2022-05-26 7:43 ` Geert Uytterhoeven
2022-05-26 8:17 ` Arnd Bergmann
2022-05-27 0:16 ` Benjamin Herrenschmidt
2022-05-23 10:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a3_4fNQV51V0-QUnuTr4dK0-S_ffeFzfA8vG1uGh8vyhg@mail.gmail.com \
--to=arnd@arndb.de \
--cc=aayarekar@marvell.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paulus@samba.org \
--cc=sburla@marvell.com \
--cc=tsbogend@alpha.franken.de \
--cc=vburru@marvell.com \
--cc=zhangyue1@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).