From: Nick Desaulniers <ndesaulniers@google.com>
To: segher@kernel.crashing.org
Cc: linuxppc-dev@lists.ozlabs.org, joel@jms.id.au
Subject: Re: [PATCH v2] powerpc/math-emu: Update macros from gmp-6.1.2
Date: Tue, 20 Nov 2018 10:45:19 -0800 [thread overview]
Message-ID: <CAKwvOdmbkZCQzFCDQUMdM-_Ds4zFDZRtr=ZbsHzVzKoEg55K7w@mail.gmail.com> (raw)
In-Reply-To: <20181120182029.GA23873@gate.crashing.org>
On Tue, Nov 20, 2018 at 10:20 AM Segher Boessenkool
<segher@kernel.crashing.org> wrote:
>
> On Tue, Nov 20, 2018 at 09:45:33AM +1030, Joel Stanley wrote:
> > On Tue, 20 Nov 2018 at 05:24, Nick Desaulniers <ndesaulniers@google.com> wrote:
> > > >
> > > > The only functional change I noticed was this in udiv_qrnnd.
> > AIUI the upstream source is GMP:
> >
> > https://gmplib.org/repo/gmp/file/tip/longlong.h
> >
> > > If we're going to borrow implementations from GCC, let's borrow the
> > > same implementation. Otherwise it's hard to have confidence in this
> > > part of the patch.
> >
> > I agree we should use the upstream source.
> >
> > Segher, which tree contains the One True Upstream for longlong.h?
>
> You should probably get your updates from the same place as was used to
> get the file in the first place.
So sounds like GMP is the source to take then. Joel, would you mind
sending a v3 with just the commit message updated to reflect the fact
that GCC and GMP differ in implementations, and this is taken from
GMP, maybe with some links? I think that will provide more context
for future travelers. I'd be happy to add my reviewed-by tag to that.
--
Thanks,
~Nick Desaulniers
next prev parent reply other threads:[~2018-11-20 18:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-14 2:44 [PATCH v2] powerpc/math-emu: Update macros from gmp-6.1.2 Joel Stanley
2018-11-19 18:53 ` Nick Desaulniers
2018-11-19 23:15 ` Joel Stanley
2018-11-20 18:20 ` Segher Boessenkool
2018-11-20 18:45 ` Nick Desaulniers [this message]
2018-11-20 20:15 ` Segher Boessenkool
2018-11-20 21:28 ` Nick Desaulniers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKwvOdmbkZCQzFCDQUMdM-_Ds4zFDZRtr=ZbsHzVzKoEg55K7w@mail.gmail.com' \
--to=ndesaulniers@google.com \
--cc=joel@jms.id.au \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).