From: Michael Guntsche <michael.guntsche@it-loops.com>
To: Scott Wood <scottwood@freescale.com>
Cc: linuxppc-dev@lists.ozlabs.org, Rojhalat Ibrahim <imr@rtschenk.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] powerpc/pci: Fix setup of Freescale PCI / PCIe controllers
Date: Tue, 18 Jun 2013 19:31:58 +0200 [thread overview]
Message-ID: <CALG0vJszdSp+HViLq3hL6BOASGrasHx34AgtUExCS3FoOa4uvw@mail.gmail.com> (raw)
In-Reply-To: <1371514253.9073.8@snotra>
On Tue, Jun 18, 2013 at 2:10 AM, Scott Wood <scottwood@freescale.com> wrote:
> On 06/17/2013 08:15:33 AM, Rojhalat Ibrahim wrote:
>>
>> On Friday 14 June 2013 15:18:03 Scott Wood wrote:
>> > On 83xx:
>> > cc1: warnings being treated as errors
>> > /home/scott/fsl/git/linux/upstream/arch/powerpc/sysdev/fsl_pci.c:100:23:
>> > error: 'fsl_indirect_pcie_ops' defined but not used
>> > make[2]: *** [arch/powerpc/sysdev/fsl_pci.o] Error 1
>> > make[2]: *** Waiting for unfinished jobs....
>> >
>> > I can fix this when applying, but this makes me wonder how you tested
>> > it, given that the whole point is to fix 83xx... Did you fix this and
>> > then accidentally sent a stale version?
>> >
>> > Also, please be careful that the patch doesn't get line wrapped -- I
>> > had to manually unwrap a couple places. Use git send-email if you
>> > can't get KMail to cooperate.
>> >
>> > -Scott
>>
>> Sorry about the mess. I'll send a v3.
>> Please note: I don't have an 83xx system. So I can only test if it
>> compiles,
>> which I obviously did not do with the right config.
>
>
> OK, so it looks like it was Michael who ran into the problem on 83xx.
> Michael, could you test the v3 patch that Rojhalat posted?
>
> -Scott
I did a quick check against -rc6 and the system compiles and boots up fine.
/Mike
prev parent reply other threads:[~2013-06-18 17:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-14 9:05 [PATCH v2] powerpc/pci: Fix setup of Freescale PCI / PCIe controllers Rojhalat Ibrahim
2013-06-14 20:18 ` Scott Wood
2013-06-17 13:15 ` Rojhalat Ibrahim
2013-06-18 0:10 ` Scott Wood
2013-06-18 17:31 ` Michael Guntsche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALG0vJszdSp+HViLq3hL6BOASGrasHx34AgtUExCS3FoOa4uvw@mail.gmail.com \
--to=michael.guntsche@it-loops.com \
--cc=imr@rtschenk.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).