From: Rob Herring <robh+dt@kernel.org>
To: Anatolij Gustschin <agust@denx.de>
Cc: devicetree@vger.kernel.org,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] powerpc/mpc512x: dts: fix PSC node warnings
Date: Thu, 14 Oct 2021 07:33:26 -0500 [thread overview]
Message-ID: <CAL_JsqJQ8_3+pwT0a-gj5iSUSo3kYZXFraejjBGObNHpB+xcTg@mail.gmail.com> (raw)
In-Reply-To: <20211014113123.2358-1-agust@denx.de>
On Thu, Oct 14, 2021 at 6:31 AM Anatolij Gustschin <agust@denx.de> wrote:
>
> Fix build warnings like:
> mpc5121.dtsi:397.13-406.5: Warning (spi_bus_bridge): /soc@80000000/psc@11400: node name for SPI buses should be 'spi'
> mpc5121.dtsi:409.13-418.5: Warning (spi_bus_bridge): /soc@80000000/psc@11500: node name for SPI buses should be 'spi'
> mpc5121.dtsi:457.13-466.5: Warning (spi_bus_bridge): /soc@80000000/psc@11900: node name for SPI buses should be 'spi'
>
> Signed-off-by: Anatolij Gustschin <agust@denx.de>
> ---
> arch/powerpc/boot/dts/ac14xx.dts | 17 +++++++++++++++--
> arch/powerpc/boot/dts/pdm360ng.dts | 11 ++++++++++-
> 2 files changed, 25 insertions(+), 3 deletions(-)
>
> diff --git a/arch/powerpc/boot/dts/ac14xx.dts b/arch/powerpc/boot/dts/ac14xx.dts
> index 5d8877e1f4ad..662d7aa2e4e8 100644
> --- a/arch/powerpc/boot/dts/ac14xx.dts
> +++ b/arch/powerpc/boot/dts/ac14xx.dts
> @@ -301,13 +301,21 @@
> fsl,tx-fifo-size = <512>;
> };
>
> + /delete-node/ psc@11400;
> + /delete-node/ psc@11500;
That's an odd way to fix this, and means every user of the .dtsi file
with these nodes will have to repeat the same thing.
> +
> /* PSC4 in SPI mode */
> - spi4: psc@11400 {
> + spi4: spi@11400 {
> compatible = "fsl,mpc5121-psc-spi", "fsl,mpc5121-psc";
> + reg = <0x11400 0x100>;
> fsl,rx-fifo-size = <768>;
> fsl,tx-fifo-size = <768>;
> #address-cells = <1>;
> #size-cells = <0>;
> + interrupts = <40 0x8>;
> + clocks = <&clks MPC512x_CLK_PSC4>,
> + <&clks MPC512x_CLK_PSC4_MCLK>;
> + clock-names = "ipg", "mclk";
> num-cs = <1>;
> cs-gpios = <&gpio_pic 25 0>;
>
> @@ -326,13 +334,18 @@
> };
>
> /* PSC5 in SPI mode */
> - spi5: psc@11500 {
> + spi5: spi@11500 {
> compatible = "fsl,mpc5121-psc-spi", "fsl,mpc5121-psc";
> + reg = <0x11500 0x100>;
> fsl,mode = "spi-master";
> fsl,rx-fifo-size = <128>;
> fsl,tx-fifo-size = <128>;
> #address-cells = <1>;
> #size-cells = <0>;
> + interrupts = <40 0x8>;
> + clocks = <&clks MPC512x_CLK_PSC5>,
> + <&clks MPC512x_CLK_PSC5_MCLK>;
> + clock-names = "ipg", "mclk";
>
> lcd@0 {
> compatible = "ilitek,ili922x";
> diff --git a/arch/powerpc/boot/dts/pdm360ng.dts b/arch/powerpc/boot/dts/pdm360ng.dts
> index 67c3b9db75d7..2733d15079a9 100644
> --- a/arch/powerpc/boot/dts/pdm360ng.dts
> +++ b/arch/powerpc/boot/dts/pdm360ng.dts
> @@ -169,10 +169,19 @@
> compatible = "fsl,mpc5121-psc-uart", "fsl,mpc5121-psc";
> };
>
> - psc@11900 {
> + /delete-node/ psc@11900;
> +
> + spi@11900 {
> compatible = "fsl,mpc5121-psc-spi", "fsl,mpc5121-psc";
> + reg = <0x11900 0x100>;
> #address-cells = <1>;
> #size-cells = <0>;
> + interrupts = <40 0x8>;
> + fsl,rx-fifo-size = <16>;
> + fsl,tx-fifo-size = <16>;
> + clocks = <&clks MPC512x_CLK_PSC9>,
> + <&clks MPC512x_CLK_PSC9_MCLK>;
> + clock-names = "ipg", "mclk";
>
> /* ADS7845 touch screen controller */
> ts@0 {
> --
> 2.17.1
>
next prev parent reply other threads:[~2021-10-14 12:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 11:31 [PATCH] powerpc/mpc512x: dts: fix PSC node warnings Anatolij Gustschin
2021-10-14 12:33 ` Rob Herring [this message]
2021-10-14 22:45 ` Anatolij Gustschin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqJQ8_3+pwT0a-gj5iSUSo3kYZXFraejjBGObNHpB+xcTg@mail.gmail.com \
--to=robh+dt@kernel.org \
--cc=agust@denx.de \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).