From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7DEA2CE7AB8 for ; Fri, 22 Sep 2023 19:46:57 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=P4ZZPqOm; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4RsjTC6mGCz3cgZ for ; Sat, 23 Sep 2023 05:46:55 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=P4ZZPqOm; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=145.40.73.55; helo=sin.source.kernel.org; envelope-from=robh@kernel.org; receiver=lists.ozlabs.org) Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4RsjSC2rqZz3c9n for ; Sat, 23 Sep 2023 05:46:03 +1000 (AEST) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id AABF0CE24D0 for ; Fri, 22 Sep 2023 19:45:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 95394C433A9 for ; Fri, 22 Sep 2023 19:45:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695411957; bh=Z73INrp+tUCDrn3nt/IznNU60OcEzvbVv581pkRDXlE=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=P4ZZPqOmhipnrgdjc5Cicuv4gwGoR5ahpSW6RraPJhB2FOCevSoVAq7M03SUqbiJq K7C83A8rvE9vTWF2PZ5kYCMKgg3G1IVvpRh+NW3hqCEKgBE5APzZ0p6is/9D0IzpXy L4KFq+qRrX7Nsl9X/FVhceTOut8PENgISZ7V9Hgc0n17gQFch+sOZHm06uwoEbBMFg bdQku4DZghgBK/X1clycJXNjGfpUaVv8cK0r9G/b2uMU+jMiHYfIm/lqjl9v/3n8cS tduJT5OdwlLHx5IjPVmN9jiMNIWgStlkcTXysI9oJM3ogbUGEUzRoqqQuRZPSge2DG XwBXMnxxa/mIQ== Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-503f39d3236so4420669e87.0 for ; Fri, 22 Sep 2023 12:45:57 -0700 (PDT) X-Gm-Message-State: AOJu0Yw0wwlgOdWWtZNp1eJqbMQdGRLjqgqQYkiSFp/W1egsMP0MZBsT FrCoOBdkOJeTTwIB1H8GkGiy7POs383Vt7wxng== X-Google-Smtp-Source: AGHT+IEyL15UWPDOOifALHGXr9zT3PFp6EFjcQQ6N5sRMKjOVNVOEvEhKETlB6KYvfp58mdiyeysUyZjSt5CkUaQLB8= X-Received: by 2002:a19:651e:0:b0:503:18c5:6833 with SMTP id z30-20020a19651e000000b0050318c56833mr310830lfb.61.1695411955742; Fri, 22 Sep 2023 12:45:55 -0700 (PDT) MIME-Version: 1.0 References: <20230922075913.422435-1-herve.codina@bootlin.com> <20230922075913.422435-26-herve.codina@bootlin.com> <169538601225.2919383.2942072541503354871.robh@kernel.org> <20230922154546.4ca18b6f@bootlin.com> In-Reply-To: <20230922154546.4ca18b6f@bootlin.com> From: Rob Herring Date: Fri, 22 Sep 2023 14:45:43 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v6 25/30] dt-bindings: net: Add the Lantiq PEF2256 E1/T1/J1 framer To: Herve Codina Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , alsa-devel@alsa-project.org, Krzysztof Kozlowski , Xiubo Li , Linus Walleij , Takashi Iwai , Eric Dumazet , Thomas Petazzoni , Li Yang , Fabio Estevam , Qiang Zhao , Shengjiu Wan g , Lee Jones , Jakub Kicinski , Paolo Abeni , devicetree@vger.kernel.org, Conor Dooley , Nicolin Chen , linux-gpio@vger.kernel.org, Mark Brown , Christophe JAILLET , Jaroslav Kysela , linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, Randy Dunlap , Liam Girdwood , linux-kernel@vger.kernel.org, Simon Horman , li nuxppc-dev@lists.ozlabs.org, "David S. Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, Sep 22, 2023 at 8:46=E2=80=AFAM Herve Codina wrote: > > Hi Rob, > > On Fri, 22 Sep 2023 07:33:32 -0500 > Rob Herring wrote: > > > On Fri, 22 Sep 2023 09:59:00 +0200, Herve Codina wrote: > > > The Lantiq PEF2256 is a framer and line interface component designed = to > > > fulfill all required interfacing between an analog E1/T1/J1 line and = the > > > digital PCM system highway/H.100 bus. > > > > > > Signed-off-by: Herve Codina > > > Reviewed-by: Christophe Leroy > > > --- > > > .../bindings/net/lantiq,pef2256.yaml | 214 ++++++++++++++++= ++ > > > 1 file changed, 214 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/net/lantiq,pef2= 256.yaml > > > > > > > My bot found errors running 'make DT_CHECKER_FLAGS=3D-m dt_binding_chec= k' > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > yamllint warnings/errors: > > > > dtschema/dtc warnings/errors: > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings= /net/lantiq,pef2256.yaml: properties:lantiq,data-rate-bps: '$ref' should no= t be valid under {'const': '$ref'} > > hint: Standard unit suffix properties don't need a type $ref > > from schema $id: http://devicetree.org/meta-schemas/core.yaml# > > > > The '-bps' suffix was added recently in > https://github.com/devicetree-org/dt-schema/ > commit 033d0b1 ("Add '-bps' as a standard unit suffix for bits per second= ") > > This commit is not yet present in any dt-schema release. > > Should I update my patch (ie. removing $ref) right now even if this updat= e will > make the last dt-schema release not happy ? Yes. I will spin a release soon as well. Rob