linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Wedson Almeida Filho <wedsonaf@google.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: paulus@samba.org, linuxppc-dev@lists.ozlabs.org,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] powerpc/module_64: use module_init_section instead of patching names
Date: Thu, 17 Feb 2022 00:08:16 +0000	[thread overview]
Message-ID: <CAMKQLN+axK+Uf2=DAf6FzLX-2CbB3XWat3_aC27-oVirsu8zEw@mail.gmail.com> (raw)
In-Reply-To: <8735kknzeh.fsf@mpe.ellerman.id.au>

[-- Attachment #1: Type: text/plain, Size: 1355 bytes --]

On Tue, 15 Feb 2022 at 11:27, Michael Ellerman <mpe@ellerman.id.au> wrote:

> Wedson Almeida Filho <wedsonaf@google.com> writes:
> > Hi Michael,
> >
> > On Wed, 2 Feb 2022 at 05:53, Wedson Almeida Filho <wedsonaf@google.com>
> wrote:
> >>
> >> Without this patch, module init sections are disabled by patching their
> >> names in arch-specific code when they're loaded (which prevents code in
> >> layout_sections from finding init sections). This patch uses the new
> >> arch-specific module_init_section instead.
> >>
> >> This allows modules that have .init_array sections to have the
> >> initialisers properly called (on load, before init). Without this patch,
> >> the initialisers are not called because .init_array is renamed to
> >> _init_array, and thus isn't found by code in find_module_sections().
> >>
> >> Signed-off-by: Wedson Almeida Filho <wedsonaf@google.com>
> >> ---
> >>  arch/powerpc/kernel/module_64.c | 11 ++++++-----
> >>  1 file changed, 6 insertions(+), 5 deletions(-)
> ...
> >
> > Would any additional clarification from my part be helpful here?
>
> Just more patience ;)
>
> > I got an email saying it was under review (and checks passed) but
> > nothing appears to have happened since.
>
> I actually put it in next late last week, but the emails got delayed due
> to various gremlins.
>

Yes, I see it, thank you!

Cheers

[-- Attachment #2: Type: text/html, Size: 2124 bytes --]

  reply	other threads:[~2022-02-17  1:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-02  5:51 [PATCH] powerpc/module_64: use module_init_section instead of patching names Wedson Almeida Filho
2022-02-15  1:49 ` Wedson Almeida Filho
2022-02-15 11:27   ` Michael Ellerman
2022-02-17  0:08     ` Wedson Almeida Filho [this message]
2022-02-15  5:26 ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMKQLN+axK+Uf2=DAf6FzLX-2CbB3XWat3_aC27-oVirsu8zEw@mail.gmail.com' \
    --to=wedsonaf@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).