From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 33C01C433F5 for ; Thu, 17 Feb 2022 01:37:24 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Jzcrf1BRtz3cDn for ; Thu, 17 Feb 2022 12:37:22 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20210112 header.b=edu3aKwK; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=google.com (client-ip=2607:f8b0:4864:20::1130; helo=mail-yw1-x1130.google.com; envelope-from=wedsonaf@google.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20210112 header.b=edu3aKwK; dkim-atps=neutral Received: from mail-yw1-x1130.google.com (mail-yw1-x1130.google.com [IPv6:2607:f8b0:4864:20::1130]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4JzZt70KYcz2ynt for ; Thu, 17 Feb 2022 11:08:30 +1100 (AEDT) Received: by mail-yw1-x1130.google.com with SMTP id 00721157ae682-2d646fffcc2so15896577b3.4 for ; Wed, 16 Feb 2022 16:08:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MJswp/06z6H2zTidNluNJt5ucFccyexftvmJcY3aUJo=; b=edu3aKwKRZZvgZ+3Mv5JKsCI8h6eWJiJlaVfXQqpb4qEW9uFQXWWBMMnUGtpKO0QCa QNEdU9+SnPoPKKprTln2NYIats33kIpC9A1zQvr3+m/ub59mYDmKW1oUDOf/7EEQNInV +AC1DQFIRp+1nFPGJI+Gy5pr7yEyqeXWKWoqQ/hWRIizbEEqN5vLBW0qHCTep77hnkX0 YN2iwUgtlt3pYFL6o/d1J0ErDwAbswMBi0ChNNns126kdgDqll9Hq+7fSjyCw7itb3t+ 9nT3EbSpUQoxdPzmZqoYBYLrIMVJs8+OnvAQpxBzqGc9Lgt8gCKcWVDRkB8ZNKBVozRO 2BjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MJswp/06z6H2zTidNluNJt5ucFccyexftvmJcY3aUJo=; b=yHjJQqTvgQ/e04OUAfZ/2YfYSOFM+HornEuwMzExP3ES/6NjeYwkkiq/x4kX3FhVyk NyzmmD7Mg3PhawSMIC9q/3L9JCKZoQJ+CnuDjYyrggxaAKg9UObwVAIxWUM6nHd6wwTQ +3bNpHIh8Ktp1FRagZflgEjIWs4sgOwVYRee6Jr6ekQpzieZu3il2EcvWe8K+XMh+gyI gX90+Ff/uw+Be6M/sqHLhvrq52+U3qG+hQiSj+HRtczc//GDIB7mDbo3H1K2tQmC8ch5 2o6UsDU47R2kagFbdhZ684CavfcuF8BAX+r0mxbx26f3agQ2b3+uGcRZ04PcaaznaAsB OIrA== X-Gm-Message-State: AOAM532vosTFNUnhXT9x8aW8if8WeNCQPMxRm7VONsVx9KjHhDZ5iQcO red7AnsEUN8UaROAHlLTM/GuRK9v1Kyp9QJ2gjkg X-Google-Smtp-Source: ABdhPJwI84Dtw8jNHVgF7S0S2h65D1i+hK2lqsMSC1l0s2mxEOLNgAFiNO08Ui8MHdSwZFiPoMLmW7GiSIqirBAnNGY= X-Received: by 2002:a0d:d0c6:0:b0:2d0:3a5a:f30b with SMTP id s189-20020a0dd0c6000000b002d03a5af30bmr352653ywd.476.1645056507846; Wed, 16 Feb 2022 16:08:27 -0800 (PST) MIME-Version: 1.0 References: <20220202055123.2144842-1-wedsonaf@google.com> <8735kknzeh.fsf@mpe.ellerman.id.au> In-Reply-To: <8735kknzeh.fsf@mpe.ellerman.id.au> From: Wedson Almeida Filho Date: Thu, 17 Feb 2022 00:08:16 +0000 Message-ID: Subject: Re: [PATCH] powerpc/module_64: use module_init_section instead of patching names To: Michael Ellerman Content-Type: multipart/alternative; boundary="000000000000c985d005d82b9046" X-Mailman-Approved-At: Thu, 17 Feb 2022 12:36:47 +1100 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: paulus@samba.org, linuxppc-dev@lists.ozlabs.org, linux-kernel Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" --000000000000c985d005d82b9046 Content-Type: text/plain; charset="UTF-8" On Tue, 15 Feb 2022 at 11:27, Michael Ellerman wrote: > Wedson Almeida Filho writes: > > Hi Michael, > > > > On Wed, 2 Feb 2022 at 05:53, Wedson Almeida Filho > wrote: > >> > >> Without this patch, module init sections are disabled by patching their > >> names in arch-specific code when they're loaded (which prevents code in > >> layout_sections from finding init sections). This patch uses the new > >> arch-specific module_init_section instead. > >> > >> This allows modules that have .init_array sections to have the > >> initialisers properly called (on load, before init). Without this patch, > >> the initialisers are not called because .init_array is renamed to > >> _init_array, and thus isn't found by code in find_module_sections(). > >> > >> Signed-off-by: Wedson Almeida Filho > >> --- > >> arch/powerpc/kernel/module_64.c | 11 ++++++----- > >> 1 file changed, 6 insertions(+), 5 deletions(-) > ... > > > > Would any additional clarification from my part be helpful here? > > Just more patience ;) > > > I got an email saying it was under review (and checks passed) but > > nothing appears to have happened since. > > I actually put it in next late last week, but the emails got delayed due > to various gremlins. > Yes, I see it, thank you! Cheers --000000000000c985d005d82b9046 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable



On Tue, 15 Feb 2022 at 11:27, Mic= hael Ellerman <mpe@ellerman.id.au<= /a>> wrote:
W= edson Almeida Filho <wedsonaf@google.com> writes:
> Hi Michael,
>
> On Wed, 2 Feb 2022 at 05:53, Wedson Almeida Filho <wedsonaf@google.com> wrote:=
>>
>> Without this patch, module init sections are disabled by patching = their
>> names in arch-specific code when they're loaded (which prevent= s code in
>> layout_sections from finding init sections). This patch uses the n= ew
>> arch-specific module_init_section instead.
>>
>> This allows modules that have .init_array sections to have the
>> initialisers properly called (on load, before init). Without this = patch,
>> the initialisers are not called because .init_array is renamed to<= br> >> _init_array, and thus isn't found by code in find_module_secti= ons().
>>
>> Signed-off-by: Wedson Almeida Filho <wedsonaf@google.com>
>> ---
>>=C2=A0 arch/powerpc/kernel/module_64.c | 11 ++++++-----
>>=C2=A0 1 file changed, 6 insertions(+), 5 deletions(-)
...
>
> Would any additional clarification from my part be helpful here?

Just more patience ;)

> I got an email saying it was under review (and checks passed) but
> nothing appears to have happened since.

I actually put it in next late last week, but the emails got delayed due to various gremlins.

Yes, I see it, tha= nk you!

Cheers=C2=A0
=C2=A0
<= /div> --000000000000c985d005d82b9046--