From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pb0-x234.google.com (mail-pb0-x234.google.com [IPv6:2607:f8b0:400e:c01::234]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id CAE7E2C007E for ; Thu, 23 May 2013 18:40:31 +1000 (EST) Received: by mail-pb0-f52.google.com with SMTP id um15so2630228pbc.39 for ; Thu, 23 May 2013 01:40:29 -0700 (PDT) MIME-Version: 1.0 Sender: geert.uytterhoeven@gmail.com In-Reply-To: <519DCBEF.3090208@asianux.com> References: <519DCBEF.3090208@asianux.com> Date: Thu, 23 May 2013 10:40:29 +0200 Message-ID: Subject: Re: [PATCH] arch: configuration, deleting 'CONFIG_BUG' since always need it. From: Geert Uytterhoeven To: Chen Gang Content-Type: text/plain; charset=UTF-8 Cc: Catalin Marinas , Linux-sh list , Heiko Carstens , "paulus@samba.org" , "H. Peter Anvin" , Michel Lespinasse , Hans-Christian Egtvedt , Linux-Arch , linux-s390@vger.kernel.org, Russell King - ARM Linux , uml-devel , Yoshinori Sato , Richard Weinberger , Helge Deller , the arch/x86 maintainers , "James E.J. Bottomley" , "mingo@redhat.com" , Frederic Weisbecker , Paul McKenney , =?UTF-8?Q?H=C3=A5vard_Skinnemoen?= , Serge Hallyn , Mike Frysinger , Arnd Bergmann , Will Deacon , Jeff Dike , Akinobu Mita , uml-user , "uclinux-dist-devel@blackfin.uclinux.org" , Thomas Gleixner , "linux-arm-kernel@lists.infradead.org" , Parisc List , "linux-kernel@vger.kernel.org" , Richard Kuo , Paul Mundt , "Eric W. Biederman" , linux-hexagon@vger.kernel.org, Martin Schwidefsky , linux390@de.ibm.com, Andrew Morton , "linuxppc-dev@lists.ozlabs.org" , David Miller List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, May 23, 2013 at 9:57 AM, Chen Gang wrote: > The crazy user can unset 'CONFIG_BUG' in menuconfig: "> General setup > > Configure standard kernel features (expert users) > BUG() Support". > > But in fact, we always need it, and quite a few of architectures have Sorry, but we don't. I think you don't get the meaning of the BUG config symbol (see below). > already implemented it (e.g. alpha, arc, arm, avr32, blackfin, cris, > frv, ia64, m68k, mips, mn10300, parisc, powerpc, s390, sh, sparc, x86). What do you mean by "already implemented it"? E.g. on m68k, I can disable or enable CONFIG_BUG. Both work. > And kernel also already has prepared a default effective implementation > for the architectures which is unwilling to implement it by themselves > (e.g. arm64, c6x, h8300, hexagon, m32r, metag, microblaze, openrisc, > score, tile, um, unicore32, xtensa). This is not about providing an implementation or not... > -config BUG > - bool "BUG() support" if EXPERT > - default y > - help > - Disabling this option eliminates support for BUG and WARN, reducing > - the size of your kernel image and potentially quietly ignoring > - numerous fatal conditions. You should only consider disabling this > - option for embedded systems with no facilities for reporting errors. > - Just say Y. ... It's about reducing memory size on devices where you can't show bug or warning messages. > So need get rid of 'CONFIG_BUG', and let it always enabled everywhere. So please keep it. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds