From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 661B3C433DF for ; Mon, 29 Jun 2020 15:45:51 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C74F825268 for ; Mon, 29 Jun 2020 15:45:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C74F825268 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 49wWzb3w6dzDqXD for ; Tue, 30 Jun 2020 01:45:47 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=209.85.210.65; helo=mail-ot1-f65.google.com; envelope-from=geert.uytterhoeven@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Received: from mail-ot1-f65.google.com (mail-ot1-f65.google.com [209.85.210.65]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 49wWvC37qKzDqMy for ; Tue, 30 Jun 2020 01:41:57 +1000 (AEST) Received: by mail-ot1-f65.google.com with SMTP id t18so3122230otq.5 for ; Mon, 29 Jun 2020 08:41:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=18DuSBZeLijFT5byeb07kqFnxpD8Og5k3o71uVKMsdg=; b=XEk5HeXIzr5fM/8ak6FNptUai4VhSfxsKbHWwPm04mGRFbBr7bnjeyUGhnLsOWHYJ+ o5o7AZ218Sk3flFNEL4A76iV18QSFDg8j5AyN+9dFy3GSNwx9YbWz+7WOWZiGi0FkZzu dS3jXaEjKiu4njpUtcGzbSNOkNutnoZAkdH9BrLER+5TgWBksL7RPwHTeGtoXj7NqazQ RrcYrI9uw+u/ZjRBC75xhpjwD6LjjQ3Dm+TsmeiyqYLftHmR5bdEqocZvCzyCMRqd/Eq wM9edRIQrVHJ/ZKHqh7DhVH66olsMCL/6AFMEhlglQ9vzf4jUUEkdlVZLDnUTFr/etwV KFBA== X-Gm-Message-State: AOAM533YUpuxozeuD5QLPSx7UUKa9CPlXyZ4BdMeVrtBeAUdkkUmjn3A jMMU3jWlhWzPYnQXrQTfM012abfElVJIlTkvFRQ= X-Google-Smtp-Source: ABdhPJyfGDnofAtWY6Vq9zQSiEjHHywgsNVHJzUbnOYeAK8rSOSVeLQNZQAOcMed2+/KO3c+bzP8Q5CiqDzs7aUNX9g= X-Received: by 2002:a05:6830:1451:: with SMTP id w17mr1238896otp.250.1593445314725; Mon, 29 Jun 2020 08:41:54 -0700 (PDT) MIME-Version: 1.0 References: <20200627143453.31835-1-rppt@kernel.org> <20200627143453.31835-2-rppt@kernel.org> In-Reply-To: <20200627143453.31835-2-rppt@kernel.org> From: Geert Uytterhoeven Date: Mon, 29 Jun 2020 17:41:43 +0200 Message-ID: Subject: Re: [PATCH 1/8] mm: remove unneeded includes of To: Mike Rapoport Content-Type: text/plain; charset="UTF-8" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-ia64@vger.kernel.org" , Linux-sh list , Peter Zijlstra , "open list:BROADCOM NVRAM DRIVER" , Max Filippov , Satheesh Rajendran , linux-csky@vger.kernel.org, sparclinux , linux-riscv , Linux-Arch , Stephen Rothwell , "open list:QUALCOMM HEXAGON..." , Joerg Roedel , Mike Rapoport , Abdul Haleem , arcml , "open list:TENSILICA XTENSA PORT \(xtensa\)" , Arnd Bergmann , linux-s390 , linux-um , Steven Rostedt , linux-m68k , Openrisc , Andy Lutomirski , Stafford Horne , Linux ARM , Parisc List , Linux MM , Linux Kernel Mailing List , alpha , Andrew Morton , linuxppc-dev Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Sat, Jun 27, 2020 at 4:35 PM Mike Rapoport wrote: > From: Mike Rapoport > > In the most cases header is required only for allocations > of page table memory. Most of the .c files that include that header do not > use symbols declared in and do not require that header. > > As for the other header files that used to include , it is > possible to move that include into the .c file that actually uses symbols > from and drop the include from the header file. > > The process was somewhat automated using > > sed -i -E '/[<"]asm\/pgalloc\.h/d' \ > $(grep -L -w -f /tmp/xx \ > $(git grep -E -l '[<"]asm/pgalloc\.h')) > > where /tmp/xx contains all the symbols defined in > arch/*/include/asm/pgalloc.h. > > Signed-off-by: Mike Rapoport For the m68k part: Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds