From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8687CC5519F for ; Mon, 30 Nov 2020 09:02:43 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E23272074A for ; Mon, 30 Nov 2020 09:02:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E23272074A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4CkzlN0QLZzDqNw for ; Mon, 30 Nov 2020 20:02:40 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=209.85.210.68; helo=mail-ot1-f68.google.com; envelope-from=geert.uytterhoeven@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Received: from mail-ot1-f68.google.com (mail-ot1-f68.google.com [209.85.210.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Ckzfj4nnPzDr1x for ; Mon, 30 Nov 2020 19:58:37 +1100 (AEDT) Received: by mail-ot1-f68.google.com with SMTP id f12so10560863oto.10 for ; Mon, 30 Nov 2020 00:58:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=X8FoExwOHfGwv6em4eg1AHlrFN+EBui3VH6c7kGHW8M=; b=e37xd/qfA5t30h1rHnNc/NNeYfDBN4XYMvILHUz/GdnatDV+a/V9bzd01eVmfCkAAK QEnvtN3ROVAYGQ+1Mci+8AOyA+lG46xUgpmSyJApk86YXpStAPjRttr0ZS4/wMU6+yN1 J3/0S8psLn64bbCKGcXjvT9sReG3j/aop2QMiv1tDWo4gXk4vyPJOPu2vNVsno/tbTZ3 Ca7qqzxcrA5GYK7SB1/EHrG0B/NcdD5Q+Q8YxwsM4nEZl8zi/JsaqB4iR7RqdzfKor9k 70vP9pW4BMY2UkPRxXpN0D84TXz2YYe5b/YY0Hivlp7pgX887sQqTQ0z2KgUeoo/2zIP LJQQ== X-Gm-Message-State: AOAM532HlLKZUEy8UwIeeoocmszRiEGp4uTohk5kpeCIKBCfIy4ZsDgC VZiKPDT7Tx+qydkpPtfcjaU9iJeXM7FUkk96yHw= X-Google-Smtp-Source: ABdhPJyrxbQKboqBlxNa7SnfyzU9JOt4/0bUzb0T5TziKWmjRC/+Hn6sbqGLcmZKse22Dhoci+I3ZQs7I9ocW0SW4DY= X-Received: by 2002:a9d:686:: with SMTP id 6mr14830891otx.107.1606726714613; Mon, 30 Nov 2020 00:58:34 -0800 (PST) MIME-Version: 1.0 References: <20201128122819.32187696@canb.auug.org.au> In-Reply-To: <20201128122819.32187696@canb.auug.org.au> From: Geert Uytterhoeven Date: Mon, 30 Nov 2020 09:58:23 +0100 Message-ID: Subject: Re: [PATCH] powerpc: fix the allyesconfig build To: Stephen Rothwell Content-Type: text/plain; charset="UTF-8" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Salil Mehta , Geert Uytterhoeven , Stephen Boyd , Michael Turquette , Linux Kernel Mailing List , Nicholas Piggin , linux-clk , Linux-Renesas , Yisen Zhuang , Joel Stanley , netdev , Jakub Kicinski , PowerPC , "David S. Miller" , Daniel Axtens Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi Stephen, On Sat, Nov 28, 2020 at 2:28 AM Stephen Rothwell wrote: > There are 2 drivers that have arrays of packed structures that contain > pointers that end up at unaligned offsets. These produce warnings in > the PowerPC allyesconfig build like this: > > WARNING: 148 bad relocations > c00000000e56510b R_PPC64_UADDR64 .rodata+0x0000000001c72378 > c00000000e565126 R_PPC64_UADDR64 .rodata+0x0000000001c723c0 > > They are not drivers that are used on PowerPC (I assume), so mark them > to not be built on PPC64 when CONFIG_RELOCATABLE is enabled. > > Cc: Geert Uytterhoeven > Cc: Michael Turquette > Cc: Stephen Boyd > Cc: Yisen Zhuang > Cc: Salil Mehta > Cc: David S. Miller > Cc: Jakub Kicinski > Cc: Nicholas Piggin > Cc: Daniel Axtens > Cc: Joel Stanley > Signed-off-by: Stephen Rothwell Thanks for your patch! > --- a/drivers/clk/renesas/Kconfig > +++ b/drivers/clk/renesas/Kconfig > @@ -151,6 +151,10 @@ config CLK_R8A779A0 > select CLK_RENESAS_CPG_MSSR > > config CLK_R9A06G032 > + # PPC64 RELOCATABLE kernels cannot handle relocations to > + # unaligned locations that are produced by the array of > + # packed structures in this driver. > + depends on !(PPC64 && RELOCATABLE) > bool "Renesas R9A06G032 clock driver" > help > This is a driver for R9A06G032 clocks I prefer to fix this in the driver instead. The space saving by packing the structure is minimal. I've sent a patch https://lore.kernel.org/r/20201130085743.1656317-1-geert+renesas@glider.be (when lore is back) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds