From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36C5AC433DF for ; Wed, 27 May 2020 07:04:57 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B206F207CB for ; Wed, 27 May 2020 07:04:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B206F207CB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 49X1zn1rSlzDqTW for ; Wed, 27 May 2020 17:04:53 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=209.85.167.193; helo=mail-oi1-f193.google.com; envelope-from=geert.uytterhoeven@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Received: from mail-oi1-f193.google.com (mail-oi1-f193.google.com [209.85.167.193]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 49X1xm25m5zDqGg for ; Wed, 27 May 2020 17:03:06 +1000 (AEST) Received: by mail-oi1-f193.google.com with SMTP id 23so19683927oiq.8 for ; Wed, 27 May 2020 00:03:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UmrgkNrS7YJyoX//CVVX8i/eCGz9CaA9GDfJeRj6hok=; b=Vlh/b50uXUVjJFWASjBCH+qDfT+HX1fYNM8lxoQm87GxQa9WhSlvMFXU2sQFbov6qx e0v4gSkgJk2WbVMgzB2RwPj86PipmguasvyGVd9gqDvltrTTkHveQNMQUE+Zz5Hxy+jv BbdsaXAd/bvneeREey0h2aQQnbTc6p6T8dFeAarJ3/y6ZhA7SfOC5yntWainjf9jk0Xk SrIe/CFmm+J2ZrNsVFVToRwD8TAov0enC3+xqwML7a4m7Gs3Y/RZQlNDqIvDPraxXPrS 4nbwRsb0AMGVvljXcQHsYeO4gVp2AdDmhzFHzf9A/OlTAjc8n1aZcw+VWBmjPp89UFLF 8X6w== X-Gm-Message-State: AOAM530EtFHq0g6lQhg5CB3qn4VeTiwRHQJJ6poijsdMQr3fRFDAQCVv UIIapULZUhuGYgS2x8dyG1DCqurwGgeGxyz7Kbk= X-Google-Smtp-Source: ABdhPJyJItgq7CbQXJlF6MFLLk/+bu/fSz/XUZ+gwTEqMYOT9P6OwO82+92+P3alNyNfXtW65E6GNWlSoFsc0hwoXsQ= X-Received: by 2002:a05:6808:1:: with SMTP id u1mr1778697oic.54.1590562983010; Wed, 27 May 2020 00:03:03 -0700 (PDT) MIME-Version: 1.0 References: <20200515143646.3857579-7-hch@lst.de> <20200527043426.3242439-1-natechancellor@gmail.com> In-Reply-To: <20200527043426.3242439-1-natechancellor@gmail.com> From: Geert Uytterhoeven Date: Wed, 27 May 2020 09:02:51 +0200 Message-ID: Subject: Re: [PATCH] media: omap3isp: Shuffle cacheflush.h and include mm.h To: Nathan Chancellor Content-Type: text/plain; charset="UTF-8" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-ia64@vger.kernel.org" , Linux-sh list , Roman Zippel , Linux Kernel Mailing List , Linux MM , Laurent Pinchart , sparclinux , linux-riscv@lists.infradead.org, Christoph Hellwig , Linux-Arch , linux-c6x-dev@linux-c6x.org, "open list:QUALCOMM HEXAGON..." , the arch/x86 maintainers , "open list:TENSILICA XTENSA PORT \(xtensa\)" , Arnd Bergmann , alpha , linux-um , linux-m68k , Openrisc , Linux ARM , Michal Simek , "open list:BROADCOM NVRAM DRIVER" , Jessica Yu , Linux FS Devel , Andrew Morton , linuxppc-dev Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi Nathan, CC Laurent On Wed, May 27, 2020 at 6:37 AM Nathan Chancellor wrote: > After mm.h was removed from the asm-generic version of cacheflush.h, > s390 allyesconfig shows several warnings of the following nature: > > In file included from ./arch/s390/include/generated/asm/cacheflush.h:1, > from drivers/media/platform/omap3isp/isp.c:42: > ./include/asm-generic/cacheflush.h:16:42: warning: 'struct mm_struct' > declared inside parameter list will not be visible outside of this > definition or declaration > > cacheflush.h does not include mm.h nor does it include any forward > declaration of these structures hence the warning. To avoid this, > include mm.h explicitly in this file and shuffle cacheflush.h below it. > > Fixes: 19c0054597a0 ("asm-generic: don't include in cacheflush.h") > Signed-off-by: Nathan Chancellor Thanks for your patch! > I am aware the fixes tag is kind of irrelevant because that SHA will > change in the next linux-next revision and this will probably get folded > into the original patch anyways but still. > > The other solution would be to add forward declarations of these structs > to the top of cacheflush.h, I just chose to do what Christoph did in the > original patch. I am happy to do that instead if you all feel that is > better. That actually looks like a better solution to me, as it would address the problem for all users. > drivers/media/platform/omap3isp/isp.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c > index a4ee6b86663e..54106a768e54 100644 > --- a/drivers/media/platform/omap3isp/isp.c > +++ b/drivers/media/platform/omap3isp/isp.c > @@ -39,8 +39,6 @@ > * Troy Laramy > */ > > -#include > - > #include > #include > #include > @@ -49,6 +47,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -58,6 +57,8 @@ > #include > #include > > +#include > + > #ifdef CONFIG_ARM_DMA_USE_IOMMU > #include > #endif Why does this file need at all? It doesn't call any of the flush_*() functions, and seems to compile fine without (on arm32). Perhaps it was included at the top intentionally, to override the definitions of copy_{to,from}_user_page()? Fortunately that doesn't seem to be the case, from a quick look at the assembler output. So let's just remove the #include instead? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds