From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Venkatram Tummala <venkatram867@gmail.com>
Cc: geoff@infradead.org, cbe-oss-dev@lists.ozlabs.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] PS3: Fixed Coding Style Issues in ps3av.c
Date: Sat, 13 Aug 2011 16:31:43 +0200 [thread overview]
Message-ID: <CAMuHMdVdA8x1NKijH4xsvbr69wOjjMn51Xn3iktbVt0N3Wthig@mail.gmail.com> (raw)
In-Reply-To: <1313139173-25049-1-git-send-email-venkatram867@gmail.com>
On Fri, Aug 12, 2011 at 10:52, Venkatram Tummala <venkatram867@gmail.com> w=
rote:
> diff --git a/drivers/ps3/ps3av.c b/drivers/ps3/ps3av.c
> index a409fa0..e6d1a3d 100644
> --- a/drivers/ps3/ps3av.c
> +++ b/drivers/ps3/ps3av.c
> @@ -26,7 +26,7 @@
> =C2=A0#include <linux/fb.h>
> =C2=A0#include <linux/slab.h>
>
> -#include <asm/firmware.h>
> +#include <linux/firmware.h>
IIRC, arch/powerpc/include/asm/firmware.h is unrelated to linux/firmware.h.
Does it actually compile when not including asm/firmware.h explicitly?
The rest looks OK to me.
Gr{oetje,eeting}s,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k=
.org
In personal conversations with technical people, I call myself a hacker. Bu=
t
when I'm talking to journalists I just say "programmer" or something like t=
hat.
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0=C2=A0 =C2=A0=C2=A0 -- Linus Torvalds
prev parent reply other threads:[~2011-08-13 14:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-12 8:52 [PATCH] PS3: Fixed Coding Style Issues in ps3av.c Venkatram Tummala
2011-08-13 14:31 ` Geert Uytterhoeven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdVdA8x1NKijH4xsvbr69wOjjMn51Xn3iktbVt0N3Wthig@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=cbe-oss-dev@lists.ozlabs.org \
--cc=geoff@infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=venkatram867@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).