From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: powerpc/spider-pci: Remove set but not used variable 'val'
Date: Fri, 2 Jul 2021 23:12:17 +0200 [thread overview]
Message-ID: <CAMuHMdVn6k16OS4NB5NEnRAHFSzSu60t1=SK4bd+xpBFSdLyYg@mail.gmail.com> (raw)
In-Reply-To: <git-mailbomb-linux-master-f377f7da26d2af87e2ddc39190546f62ecdb2bd8@kernel.org>
Hi Michael,
On Fri, Jul 2, 2021 at 10:14 PM Linux Kernel Mailing List
<linux-kernel@vger.kernel.org> wrote:
> Commit: f377f7da26d2af87e2ddc39190546f62ecdb2bd8
> Parent: 911bacda4658129bee039dc90fc0c3f193ee2695
> Refname: refs/heads/master
> Web: https://git.kernel.org/torvalds/c/f377f7da26d2af87e2ddc39190546f62ecdb2bd8
> Author: Baokun Li <libaokun1@huawei.com>
> AuthorDate: Tue Jun 1 16:53:19 2021 +0800
> Committer: Michael Ellerman <mpe@ellerman.id.au>
> CommitDate: Tue Jun 15 17:12:27 2021 +1000
>
> powerpc/spider-pci: Remove set but not used variable 'val'
>
> Fixes gcc '-Wunused-but-set-variable' warning:
> # WARNING: Fixes tag on line 3 doesn't match correct format
> # WARNING: Fixes tag on line 3 doesn't match correct format
> # WARNING: Fixes tag on line 3 doesn't match correct format
> # WARNING: Fixes tag on line 3 doesn't match correct format
> # WARNING: Fixes tag on line 3 doesn't match correct format
> # WARNING: Fixes tag on line 3 doesn't match correct format
Which tools is adding these warnings to various commit descriptions?
> arch/powerpc/platforms/cell/spider-pci.c: In function 'spiderpci_io_flush':
> arch/powerpc/platforms/cell/spider-pci.c:28:6: warning:
> variable ‘val’ set but not used [-Wunused-but-set-variable]
>
> It never used since introduction.
>
> Signed-off-by: Baokun Li <libaokun1@huawei.com>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> Link: https://lore.kernel.org/r/20210601085319.140461-1-libaokun1@huawei.com
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
parent reply other threads:[~2021-07-02 21:12 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <git-mailbomb-linux-master-f377f7da26d2af87e2ddc39190546f62ecdb2bd8@kernel.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdVn6k16OS4NB5NEnRAHFSzSu60t1=SK4bd+xpBFSdLyYg@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).