Re: powerpc/spider-pci: Remove set but not used variable 'val'

Re: powerpc/spider-pci: Remove set but not used variable 'val'

[Geert Uytterhoeven]

Hi Michael,

On Fri, Jul 2, 2021 at 10:14 PM Linux Kernel Mailing List
<linux-kernel@vger.kernel.org> wrote:
> Commit:     f377f7da26d2af87e2ddc39190546f62ecdb2bd8
> Parent:     911bacda4658129bee039dc90fc0c3f193ee2695
> Refname:    refs/heads/master
> Web:        https://git.kernel.org/torvalds/c/f377f7da26d2af87e2ddc39190546f62ecdb2bd8
> Author:     Baokun Li <libaokun1@huawei.com>
> AuthorDate: Tue Jun 1 16:53:19 2021 +0800
> Committer:  Michael Ellerman <mpe@ellerman.id.au>
> CommitDate: Tue Jun 15 17:12:27 2021 +1000
>
>     powerpc/spider-pci: Remove set but not used variable 'val'
>
>     Fixes gcc '-Wunused-but-set-variable' warning:
>     # WARNING: Fixes tag on line 3 doesn't match correct format
>     # WARNING: Fixes tag on line 3 doesn't match correct format
>     # WARNING: Fixes tag on line 3 doesn't match correct format
>     # WARNING: Fixes tag on line 3 doesn't match correct format
>     # WARNING: Fixes tag on line 3 doesn't match correct format
>     # WARNING: Fixes tag on line 3 doesn't match correct format

Which tools is adding these warnings to various commit descriptions?

>     arch/powerpc/platforms/cell/spider-pci.c: In function 'spiderpci_io_flush':
>     arch/powerpc/platforms/cell/spider-pci.c:28:6: warning:
>     variable ‘val’ set but not used [-Wunused-but-set-variable]
>
>     It never used since introduction.
>
>     Signed-off-by: Baokun Li <libaokun1@huawei.com>
>     Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
>     Link: https://lore.kernel.org/r/20210601085319.140461-1-libaokun1@huawei.com

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds