From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 264AAC07E95 for ; Fri, 2 Jul 2021 21:12:55 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8091C61176 for ; Fri, 2 Jul 2021 21:12:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8091C61176 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4GGnq91SKjz3bk2 for ; Sat, 3 Jul 2021 07:12:53 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=209.85.222.47; helo=mail-ua1-f47.google.com; envelope-from=geert.uytterhoeven@gmail.com; receiver=) Received: from mail-ua1-f47.google.com (mail-ua1-f47.google.com [209.85.222.47]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4GGnpp3hdSz3014 for ; Sat, 3 Jul 2021 07:12:32 +1000 (AEST) Received: by mail-ua1-f47.google.com with SMTP id x37so4316519uac.13 for ; Fri, 02 Jul 2021 14:12:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=iWmsu/MAqdEYVnC17Jds+nQkby43Df87NTtUM3jHHqE=; b=j+F/pvTqUaaeGFKfrZUSqhG9q/puNO4OlYi8cH0z56zDIiG67m0NDfGLZpUGv1oGFm /VXgTAeXJpp5mRorK2Ca5WcG1RYF7yF4MVBbop5kx4Vsb/vQ03SM7ujZRKS6fuQMilrT 9Hgc3+AA7YxraN/1zotmBE6oSP+MKr3eWaA+zO0hhl6xxTPNDsIPAmlEI82rUA+cSBpC Fq1YY1qbXkpaZP468YNV8Ob9lxWlvV6mrjuYgWc02+U7DpfYOWara8qYmNj6T/rzGeX4 HJUYL6jFjLUdU+8c/pslAxikPyjUsrJjTmMm6W4hHf/nw0FIbilmv2zVZzpsmY1G5doM IcJA== X-Gm-Message-State: AOAM533mjYRmD43Wcgyq8aB+POdzrKEn+cqjhHFWJNxltA8Zy0eCi8mw fEloXGFdn+bSbvPVZfc5NzxNPH2ql2m2wvBO+YUHhiDS X-Google-Smtp-Source: ABdhPJwFWeUtP8wudZfNwbQ+DaTooM2VLLb988TYTLhMSFaTbFsTt83dii8Q+aFlknLwfrxfTjLyTaJW7401xFUOgRs= X-Received: by 2002:ab0:71c1:: with SMTP id n1mr2542722uao.2.1625260349128; Fri, 02 Jul 2021 14:12:29 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Geert Uytterhoeven Date: Fri, 2 Jul 2021 23:12:17 +0200 Message-ID: Subject: Re: powerpc/spider-pci: Remove set but not used variable 'val' To: Michael Ellerman Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linuxppc-dev Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi Michael, On Fri, Jul 2, 2021 at 10:14 PM Linux Kernel Mailing List wrote: > Commit: f377f7da26d2af87e2ddc39190546f62ecdb2bd8 > Parent: 911bacda4658129bee039dc90fc0c3f193ee2695 > Refname: refs/heads/master > Web: https://git.kernel.org/torvalds/c/f377f7da26d2af87e2ddc391905= 46f62ecdb2bd8 > Author: Baokun Li > AuthorDate: Tue Jun 1 16:53:19 2021 +0800 > Committer: Michael Ellerman > CommitDate: Tue Jun 15 17:12:27 2021 +1000 > > powerpc/spider-pci: Remove set but not used variable 'val' > > Fixes gcc '-Wunused-but-set-variable' warning: > # WARNING: Fixes tag on line 3 doesn't match correct format > # WARNING: Fixes tag on line 3 doesn't match correct format > # WARNING: Fixes tag on line 3 doesn't match correct format > # WARNING: Fixes tag on line 3 doesn't match correct format > # WARNING: Fixes tag on line 3 doesn't match correct format > # WARNING: Fixes tag on line 3 doesn't match correct format Which tools is adding these warnings to various commit descriptions? > arch/powerpc/platforms/cell/spider-pci.c: In function 'spiderpci_io_f= lush': > arch/powerpc/platforms/cell/spider-pci.c:28:6: warning: > variable =E2=80=98val=E2=80=99 set but not used [-Wunused-but-set-var= iable] > > It never used since introduction. > > Signed-off-by: Baokun Li > Signed-off-by: Michael Ellerman > Link: https://lore.kernel.org/r/20210601085319.140461-1-libaokun1@hua= wei.com Gr{oetje,eeting}s, Geert --=20 Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds