From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56E89C2D0E4 for ; Fri, 27 Nov 2020 08:42:08 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 663A822226 for ; Fri, 27 Nov 2020 08:42:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 663A822226 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4Cj7R11XlKzDrg3 for ; Fri, 27 Nov 2020 19:42:05 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=209.85.210.67; helo=mail-ot1-f67.google.com; envelope-from=geert.uytterhoeven@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Received: from mail-ot1-f67.google.com (mail-ot1-f67.google.com [209.85.210.67]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Cj7Ny0YbRzDrTM for ; Fri, 27 Nov 2020 19:40:17 +1100 (AEDT) Received: by mail-ot1-f67.google.com with SMTP id f12so4024241oto.10 for ; Fri, 27 Nov 2020 00:40:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=/D+lVsFpiig9p8Mfv+F/WnI4wKF69UpUHln9lDG06g4=; b=ACo988DjGxPfrrpqZ/JOA5es7MXvgV+nUDA0zqSJo5eaUnG7hLAvz5Ry9z87m0BVpI 6Qqtmgmydw4nRO0Mfj8T+zzVR5xCOdh3f+LzXrLrYEvdXQah8T/LrnuzfaTtn8pHAr7H 4dc1TgE9HJXm4Z5nwdYiDV8x7+JPRhiL7Z7MHzIsPElV5cH3Pw+SzqhZ2ZW1WPxI0ZEu T9oxhbdK4YgSlni4gm9c0t3O0m47xcfHByb87UUnqvj11ewOzIWprJrbsDzc37Owq+pa cPya8ldt0QidIhG7I3Nju2xP7aggkIeDit50DKlPuFD1/J8XhAHbXhDdk0mJPD22ADrW zytw== X-Gm-Message-State: AOAM532GAbgkLzrWRPgxEDB4OrBqikl8N8rQoI8wxho5jA3/WbzKkOtJ KJF+eJ1Fi7p5pDzu+aUwjfqVtip0vXv1dzG6q8fvQnzzh1oQJA== X-Google-Smtp-Source: ABdhPJy2I/IdfAm6V2ydZbwLB9NPNLYo9PucEpxX/NL/qzuCx8bfpYwJU7BhpITpgvBGwlFRBVNr8EmnqamS0CIYUsg= X-Received: by 2002:a9d:686:: with SMTP id 6mr4709371otx.107.1606466415531; Fri, 27 Nov 2020 00:40:15 -0800 (PST) MIME-Version: 1.0 References: <20201126165950.2554997-1-u.kleine-koenig@pengutronix.de> <20201126165950.2554997-2-u.kleine-koenig@pengutronix.de> In-Reply-To: <20201126165950.2554997-2-u.kleine-koenig@pengutronix.de> From: Geert Uytterhoeven Date: Fri, 27 Nov 2020 09:40:04 +0100 Message-ID: Subject: Re: [PATCH 2/2] powerpc/ps3: make system bus's remove and shutdown callbacks return void To: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ALSA Development Mailing List , Linux Fbdev development list , DRI Development , Jaroslav Kysela , Paul Mackerras , scsi , Alan Stern , Jakub Kicinski , Arnd Bergmann , Bartlomiej Zolnierkiewicz , "James E.J. Bottomley" , linux-block@vger.kernel.org, Jens Axboe , "Martin K. Petersen" , Geoff Levand , netdev , USB list , Takashi Iwai , Jim Paris , Greg Kroah-Hartman , linuxppc-dev , "David S. Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi Uwe, On Thu, Nov 26, 2020 at 6:03 PM Uwe Kleine-K=C3=B6nig wrote: > The driver core ignores the return value of struct device_driver::remove > because there is only little that can be done. For the shutdown callback > it's ps3_system_bus_shutdown() which ignores the return value. > > To simplify the quest to make struct device_driver::remove return void, > let struct ps3_system_bus_driver::remove return void, too. All users > already unconditionally return 0, this commit makes it obvious that > returning an error code is a bad idea and ensures future users behave > accordingly. > > Signed-off-by: Uwe Kleine-K=C3=B6nig Thanks for your patch! Reviewed-by: Geert Uytterhoeven Note that the same can be done for ps3_vuart_port_driver.remove(). Gr{oetje,eeting}s, Geert --=20 Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds