From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Tom Musta <tommusta@gmail.com>
Cc: linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
tmusta@gmail.com, Andreas Schwab <schwab@linux-m68k.org>
Subject: Re: [PATCH 1/3] powerpc: Enable emulate_step In Little Endian Mode
Date: Wed, 30 Oct 2013 20:43:47 +0100 [thread overview]
Message-ID: <CAMuHMdWMZNF_KOMyVES2UbvCyGEH1N=CFp-TTWuLMzm89SLs3A@mail.gmail.com> (raw)
In-Reply-To: <52715F7F.8020206@gmail.com>
On Wed, Oct 30, 2013 at 8:35 PM, Tom Musta <tommusta@gmail.com> wrote:
> On 10/30/2013 12:43 PM, Andreas Schwab wrote:
>>
>> Tom Musta <tommusta@gmail.com> writes:
>>
>>> +#ifdef __LITTLE_ENDIAN__
>>> + if (!regs->msr & MSR_LE)
>>
>>
>> That won't work.
>>
>> Andreas.
>>
>
> Please elaborate.
You want to test for "!(regs & MSR_LE)".
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2013-10-30 19:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-18 19:38 [PATCH 0/3] powerpc: Fix Little Endian Bugs in Single Step Code Tom Musta
2013-10-18 19:40 ` [PATCH 1/3] powerpc: Enable emulate_step In Little Endian Mode Tom Musta
2013-10-30 0:13 ` Benjamin Herrenschmidt
2013-10-30 17:43 ` Andreas Schwab
2013-10-30 19:35 ` Tom Musta
2013-10-30 19:43 ` Geert Uytterhoeven [this message]
2013-10-30 21:45 ` Tom Musta
2013-10-18 19:42 ` [PATCH 2/3] powerpc: Fix Unaligned Loads and Stores Tom Musta
2013-10-18 19:44 ` [PATCH 3/3] powerpc: Fix Unaligned LE Floating Point " Tom Musta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdWMZNF_KOMyVES2UbvCyGEH1N=CFp-TTWuLMzm89SLs3A@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=schwab@linux-m68k.org \
--cc=tmusta@gmail.com \
--cc=tommusta@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).