From: Brian Norris <computersforpeace@gmail.com>
To: dedekind1@gmail.com
Cc: b35362@freescale.com, linuxppc-dev@linux.freescale.net,
linuxppc-dev@ozlabs.org, linux-mtd@lists.infradead.org,
dwmw2@infradead.org
Subject: Re: [PATCH] mtd-utils: fix corrupt cleanmarker with flash_erase -j command
Date: Tue, 16 Aug 2011 12:42:15 -0700 [thread overview]
Message-ID: <CAN8TOE8sD3cPjkTrLWMXFH58gURTuiBWYDFA+XLK_MKDMb9-5g@mail.gmail.com> (raw)
In-Reply-To: <1313507201.2679.2.camel@sauron>
On Tue, Aug 16, 2011 at 8:06 AM, Artem Bityutskiy <dedekind1@gmail.com> wrote:
> On Wed, 2011-08-03 at 13:50 +0800, b35362@freescale.com wrote:
>> From: Liu Shuo <b35362@freescale.com>
>>
>> Flash_erase -j should fill discrete freeoob areas with required bytes
>> of JFFS2 cleanmarker in jffs2_check_nand_cleanmarker(). Not just fill
>> the first freeoob area.
>
> Hmm, shouldn't we instead make MTD_OOB_AUTO be available for userspace
> via an ioctl instead and make flash_eraseall use it instead?
`nandwrite -o' does a similar thing, where it uses MEMGETOOBSEL to
find open spaces in OOB. Both MEMGETOOBSEL and ECCGETLAYOUT have been
declared obsolete. Plus, the code that uses any of these is somewhat
complicated and duplicated, so I agree that new code probably should
use some form of the internal MTD_OOB_AUTO.
Perhaps this can just be integrated into the new ioctl I'm writing as
a "mode" choice? See the thread:
http://lists.infradead.org/pipermail/linux-mtd/2011-August/037316.html
Brian
next prev parent reply other threads:[~2011-08-16 19:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-03 5:50 [PATCH] mtd-utils: fix corrupt cleanmarker with flash_erase -j command b35362
2011-08-16 15:06 ` Artem Bityutskiy
2011-08-16 19:42 ` Brian Norris [this message]
2011-08-17 7:35 ` LiuShuo
2011-08-17 7:39 ` Artem Bityutskiy
2011-08-18 1:20 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAN8TOE8sD3cPjkTrLWMXFH58gURTuiBWYDFA+XLK_MKDMb9-5g@mail.gmail.com \
--to=computersforpeace@gmail.com \
--cc=b35362@freescale.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linuxppc-dev@linux.freescale.net \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).