From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Maninder Singh <maninder1.s@samsung.com>
Cc: nathanl@linux.ibm.com, bcain@quicinc.com, keescook@chromium.org,
gary@garyguo.net, pmladek@suse.com, ustavoars@kernel.org,
linux-kernel@vger.kernel.org, Onkarnath <onkarnath.1@samsung.com>,
wedsonaf@google.com, npiggin@gmail.com, alex.gaynor@gmail.com,
linux-hexagon@vger.kernel.org, ojeda@kernel.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 1/2] hexagon/traps.c: use KSYM_NAME_LEN in array size
Date: Tue, 30 May 2023 14:59:15 +0200 [thread overview]
Message-ID: <CANiq72nTqbof=SThq-PRhz=ks2WRvdUXBzJoesyXUmB2KB5pmA@mail.gmail.com> (raw)
In-Reply-To: <20230529111337.352990-1-maninder1.s@samsung.com>
On Mon, May 29, 2023 at 1:14 PM Maninder Singh <maninder1.s@samsung.com> wrote:
>
> kallsyms_lookup which in turn calls for kallsyms_lookup_buildid()
> writes on index "KSYM_NAME_LEN - 1".
>
> Thus array size should be KSYM_NAME_LEN.
>
> for hexagon it was defined as "128" directly.
> and commit '61968dbc2d5d' changed define value to 512,
> So both were missed to update with new size.
>
> Fixes: 61968dbc2d5d ("kallsyms: increase maximum kernel symbol length to 512")
>
> Co-developed-by: Onkarnath <onkarnath.1@samsung.com>
> Signed-off-by: Onkarnath <onkarnath.1@samsung.com>
> Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
With the updated commit hash:
Reviewed-by: Miguel Ojeda <ojeda@kernel.org>
Cheers,
Miguel
next prev parent reply other threads:[~2023-05-30 13:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230529111350epcas5p46a1fa16ffb2a39008c26d03c5c63f109@epcas5p4.samsung.com>
2023-05-29 11:13 ` [PATCH 1/2] hexagon/traps.c: use KSYM_NAME_LEN in array size Maninder Singh
[not found] ` <CGME20230529111404epcas5p2d540d726dcf3e21aae2a6a0958e2eea5@epcas5p2.samsung.com>
2023-05-29 11:13 ` [PATCH 2/2] powerpc/xmon: " Maninder Singh
2023-05-30 6:45 ` Michael Ellerman
2023-05-30 12:54 ` Miguel Ojeda
2023-06-01 2:02 ` Michael Ellerman
2023-06-01 10:27 ` Miguel Ojeda
2023-06-01 12:54 ` Michael Ellerman
2023-08-03 5:46 ` Benjamin Gray
2023-05-30 8:59 ` [PATCH 1/2] hexagon/traps.c: " Petr Mladek
2023-05-30 12:59 ` Miguel Ojeda [this message]
2023-05-30 13:42 ` David Laight
2023-07-03 4:02 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANiq72nTqbof=SThq-PRhz=ks2WRvdUXBzJoesyXUmB2KB5pmA@mail.gmail.com' \
--to=miguel.ojeda.sandonis@gmail.com \
--cc=alex.gaynor@gmail.com \
--cc=bcain@quicinc.com \
--cc=gary@garyguo.net \
--cc=keescook@chromium.org \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maninder1.s@samsung.com \
--cc=nathanl@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=ojeda@kernel.org \
--cc=onkarnath.1@samsung.com \
--cc=pmladek@suse.com \
--cc=ustavoars@kernel.org \
--cc=wedsonaf@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).