From: Denis Kirjanov <kda@linux-powerpc.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] powerpc: tracing: don't trace hcalls on offline CPUs
Date: Mon, 14 Dec 2015 13:05:48 +0300 [thread overview]
Message-ID: <CAOJe8K3nx8MTu77XyBAyUZNOLrEKzph00SsL47yYyJTx5wbO9Q@mail.gmail.com> (raw)
In-Reply-To: <1450087241.9595.0.camel@ellerman.id.au>
On 12/14/15, Michael Ellerman <mpe@ellerman.id.au> wrote:
> On Mon, 2015-12-07 at 16:33 -0500, Steven Rostedt wrote:
>> On Tue, 08 Dec 2015 08:02:15 +1100
>> Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
>> > On Mon, 2015-12-07 at 15:52 -0500, Steven Rostedt wrote:
>> > > > + TP_CONDITION(cpu_online(smp_processor_id())),
>> > > > +
>> >
>> > This should probably be some kind of __raw version though, hcalls can
>> > be called in contexts where the debug stuff in smp_processor_id() isn't
>> > safe (or preempt enabled).
>> >
>>
>> OK, then that needs to be updated.
>
> Denis, please respin with raw_smp_processor_id().
Sure, I'll respin today.
Thanks!
>
> cheers
>
>
next prev parent reply other threads:[~2015-12-14 10:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-24 18:23 [PATCH 1/2] tracing: introduce TRACE_EVENT_FN_COND macro Denis Kirjanov
2015-11-24 18:23 ` [PATCH 2/2] powerpc: tracing: don't trace hcalls on offline CPUs Denis Kirjanov
2015-11-26 6:39 ` Michael Ellerman
2015-11-26 8:15 ` Denis Kirjanov
2015-11-26 9:26 ` Michael Ellerman
2015-11-26 20:10 ` Denis Kirjanov
2015-12-07 20:52 ` Steven Rostedt
2015-12-07 21:02 ` Benjamin Herrenschmidt
2015-12-07 21:33 ` Steven Rostedt
2015-12-14 10:00 ` Michael Ellerman
2015-12-14 10:05 ` Denis Kirjanov [this message]
2015-12-07 14:42 ` [PATCH 1/2] tracing: introduce TRACE_EVENT_FN_COND macro Denis Kirjanov
2015-12-07 14:57 ` Steven Rostedt
2015-12-11 19:40 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOJe8K3nx8MTu77XyBAyUZNOLrEKzph00SsL47yYyJTx5wbO9Q@mail.gmail.com \
--to=kda@linux-powerpc.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).