From: Fabio Estevam <festevam@gmail.com>
To: Andreas Henriksson <andreas@fatal.se>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
"Xiubo Li" <Xiubo.Lee@gmail.com>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
"Shengjiu Wang" <shengjiu.wang@nxp.com>,
"Takashi Iwai" <tiwai@suse.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Jaroslav Kysela" <perex@perex.cz>,
"Nicolin Chen" <nicoleotsuka@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Hans Söderlund" <hans.soderlund@realbit.se>,
"Shengjiu Wang" <shengjiu.wang@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: fsl_sai: Enable MCTL_MCLK_EN bit for master mode
Date: Thu, 6 Jul 2023 10:22:12 -0300 [thread overview]
Message-ID: <CAOMZO5AFjS+aGjHTYCvPO86ypXfcFnuKmU2qHZNTyDSQPxRHjQ@mail.gmail.com> (raw)
In-Reply-To: <20230706123401.kctossjho26bry7e@fatal.se>
Hi Andreas,
On Thu, Jul 6, 2023 at 9:34 AM Andreas Henriksson <andreas@fatal.se> wrote:
> I think your initial review comment was spot on Fabio. There probably
> needs to be a(n imx8mm) specific flag that says when this workaround
> should be applied and gate the code in bclk function on that.
> Atleast that's the only thing I can think of if my interpretation of the
> problem for imx8mm is correct.
Yes, deciding whether MCLK_EN should act as a clock gate based on
the number of SAI registers seems fragile to me.
I have sent a proposal as RFC. Please give it a try if you have a chance.
I would like Shengjiu to confirm if imx8mn and imx93 should also
behave like imx8mm in this aspect.
Cheers
next prev parent reply other threads:[~2023-07-06 13:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 12:36 [PATCH] ASoC: fsl_sai: Enable MCTL_MCLK_EN bit for master mode Shengjiu Wang
2022-05-19 13:23 ` Fabio Estevam
2022-05-19 13:41 ` Shengjiu Wang
2023-07-06 8:47 ` Andreas Henriksson
2023-07-06 11:06 ` Shengjiu Wang
2023-07-06 11:08 ` Fabio Estevam
2023-07-06 11:19 ` Shengjiu Wang
2023-07-06 11:32 ` Fabio Estevam
2023-07-06 12:34 ` Andreas Henriksson
2023-07-06 13:22 ` Fabio Estevam [this message]
2023-07-06 22:00 ` Fabio Estevam
2022-06-08 20:46 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOMZO5AFjS+aGjHTYCvPO86ypXfcFnuKmU2qHZNTyDSQPxRHjQ@mail.gmail.com \
--to=festevam@gmail.com \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=andreas@fatal.se \
--cc=broonie@kernel.org \
--cc=hans.soderlund@realbit.se \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nicoleotsuka@gmail.com \
--cc=perex@perex.cz \
--cc=shengjiu.wang@gmail.com \
--cc=shengjiu.wang@nxp.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).