From: Fabio Estevam <festevam@gmail.com>
To: Yuanjun Gong <ruc_gongyuanjun@163.com>
Cc: linuxppc-dev@lists.ozlabs.org, shengjiu.wang@gmail.com,
Xiubo.Lee@gmail.com
Subject: Re: [PATCH v2 1/1] ASoC: imx-audmux: fix return value checks of clk_prepare_enable()
Date: Sat, 22 Jul 2023 09:40:48 -0300 [thread overview]
Message-ID: <CAOMZO5AXY7ThO0dTLc47xE7a61k9QEXMTbgSAx2Dqy_3RJxoTg@mail.gmail.com> (raw)
In-Reply-To: <20230722123635.26623-1-ruc_gongyuanjun@163.com>
On Sat, Jul 22, 2023 at 9:38 AM Yuanjun Gong <ruc_gongyuanjun@163.com> wrote:
>
> check the return value of clk_prepare_enable(), and if
> clk_prepare_enable() gets an unexpected return value,
> imx_audmux_suspend() and imx_audmux_resume() should return
> the error value.
>
> Signed-off-by: Yuanjun Gong <ruc_gongyuanjun@163.com>
> ---
> sound/soc/fsl/imx-audmux.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/fsl/imx-audmux.c b/sound/soc/fsl/imx-audmux.c
> index be003a117b39..9791e56158ef 100644
> --- a/sound/soc/fsl/imx-audmux.c
> +++ b/sound/soc/fsl/imx-audmux.c
> @@ -325,8 +325,11 @@ static void imx_audmux_remove(struct platform_device *pdev)
> static int imx_audmux_suspend(struct device *dev)
> {
> int i;
> + ssize_t ret;
Why not simply "int ret" instead?
next prev parent reply other threads:[~2023-07-22 12:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 14:51 [PATCH 1/1] sound:soc: fix return value check in imx_audmux_suspend Yuanjun Gong
2023-07-21 8:40 ` Shengjiu Wang
2023-07-22 12:36 ` [PATCH v2 1/1] ASoC: imx-audmux: fix return value checks of clk_prepare_enable() Yuanjun Gong
2023-07-22 12:40 ` Fabio Estevam [this message]
2023-07-25 1:47 ` [PATCH v3 " Yuanjun Gong
2023-07-28 4:29 ` [PATCH v2 " Shengjiu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOMZO5AXY7ThO0dTLc47xE7a61k9QEXMTbgSAx2Dqy_3RJxoTg@mail.gmail.com \
--to=festevam@gmail.com \
--cc=Xiubo.Lee@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=ruc_gongyuanjun@163.com \
--cc=shengjiu.wang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).