From: Fabio Estevam <festevam@gmail.com>
To: Emil Abildgaard Svendsen <EMAS@bang-olufsen.dk>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Xiubo Li <Xiubo.Lee@gmail.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>,
Nicolin Chen <nicoleotsuka@gmail.com>,
Mark Brown <broonie@kernel.org>,
Matus Gajdos <matuszpd@gmail.com>,
Shengjiu Wang <shengjiu.wang@gmail.com>
Subject: Re: [PATCH] ASoC: fsl_sai: sw reset consumer on pause/stop
Date: Thu, 21 Sep 2023 11:00:20 -0300 [thread overview]
Message-ID: <CAOMZO5B2L4OxtDTcUhn_w3K5zimDMOFB--DVL_d6TjeBjD5VUQ@mail.gmail.com> (raw)
In-Reply-To: <20230921084808.840381-1-emas@bang-olufsen.dk>
On Thu, Sep 21, 2023 at 5:48 AM Emil Abildgaard Svendsen
<EMAS@bang-olufsen.dk> wrote:
>
> When in consumer mode with BCLK disabled (FSL_SAI_CSR_BCE = 0) the
> FIFO's can still contain data when resumed. It might also be possible
> with BCLK enabled but just less likely.
>
> When the FIFO's still contain data on resume it can cause channel
> shifting on e.g. XRUNS. A Software Reset will reset the FIFO's and make
> sure channels are aligned.
>
> Fixes: 269f399dc19f ("ASoC: fsl_sai: Disable bit clock with transmitter")
> Signed-off-by: Emil Svendsen <emas@bang-olufsen.dk>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
prev parent reply other threads:[~2023-09-21 14:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-21 8:48 [PATCH] ASoC: fsl_sai: sw reset consumer on pause/stop Emil Abildgaard Svendsen
2023-09-21 14:00 ` Fabio Estevam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOMZO5B2L4OxtDTcUhn_w3K5zimDMOFB--DVL_d6TjeBjD5VUQ@mail.gmail.com \
--to=festevam@gmail.com \
--cc=EMAS@bang-olufsen.dk \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=matuszpd@gmail.com \
--cc=nicoleotsuka@gmail.com \
--cc=perex@perex.cz \
--cc=shengjiu.wang@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).