From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0D53C432BE for ; Thu, 26 Aug 2021 11:53:56 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2A2D86108D for ; Thu, 26 Aug 2021 11:53:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2A2D86108D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4GwLpp55zpz302N for ; Thu, 26 Aug 2021 21:53:54 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=FB0fHEaV; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2a00:1450:4864:20::22d; helo=mail-lj1-x22d.google.com; envelope-from=festevam@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=FB0fHEaV; dkim-atps=neutral Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4GwLp14Tszz2xrk for ; Thu, 26 Aug 2021 21:53:12 +1000 (AEST) Received: by mail-lj1-x22d.google.com with SMTP id i28so4587300ljm.7 for ; Thu, 26 Aug 2021 04:53:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hBxBPr3Kmhx+gtlKVfwmBEiG03qJgZIhVmQgwh7w3cs=; b=FB0fHEaVXvKluHgvDlnT+jczLkZlGErjJJcgRmo6eZQTf8xdHEvDAuWFcB/QkxF4am 7sLfKCqAoC/rjaaZHeVT2p9sjEtnFNvrhixpDYcebthv5V3m1B5T6dFAzyInBteoOSNd y9P1RkLqYOd5FxhAiqyQxxXLQBsMJMWpioS0KfxUkaik13asCvQy42uEp/vg36WtcETW oHKYlfRq4qtHu5Lycp66zFgKzPZ7iorXB4UMbRosPksChFZByPmFLl8EsXkWmWG6hv6h LImOeUz3lp8A2xT7OPoa+JpAxsfvM8+5SVf5hb3uUjEoDbQoU/rBuk342Bvys2IgoDKu uZeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hBxBPr3Kmhx+gtlKVfwmBEiG03qJgZIhVmQgwh7w3cs=; b=GrNT0+sdkn6W02ef+Zei8RPno9pjcH6X+PTHlBjKF0CO0sEfcBldV0B2S+QOB5CYj0 Lajr0wanb75I2Bl3KNJYEn1jib06wjsmCL/+pBijlfnnoI5vfJPBRVlW0LcjtLVlGVie YMokcEW9EU2jEx/WGZ9BaLJO/YAY4F/iT1kre1lBsUV9YOOgTGB8e+Gv67frXRsVkJJH mPFl2b1607HimZOQ1e1igQTBei4AI2B+kXMA1xcNEVu5CIzGDZjTlo9TSqA7TkHEcx55 qdzN6EsYioOQNeFrzl1wFiw2SG2PnIWoLYNTUjgTYVIepqgqtlxn0os53w+jlzPpjCw9 9u7Q== X-Gm-Message-State: AOAM531e5L7bjCcD3Du7+s3UABgRt6kmiheCQn4vXlvVw9XliOGXnIYa nQCepTraQMlrIl0GmPK51vyW0c1lCRUvTtLkJMM= X-Google-Smtp-Source: ABdhPJz7/MeHPulwySfsZ/IqdizUu7xk9XmvlQXItyDL8PXG0Cim011tjNevkpfh3ADXQSZ3F7nxSBrSo9s72Oey3Go= X-Received: by 2002:a2e:a903:: with SMTP id j3mr2694040ljq.347.1629978784221; Thu, 26 Aug 2021 04:53:04 -0700 (PDT) MIME-Version: 1.0 References: <1629975460-17990-1-git-send-email-shengjiu.wang@nxp.com> In-Reply-To: <1629975460-17990-1-git-send-email-shengjiu.wang@nxp.com> From: Fabio Estevam Date: Thu, 26 Aug 2021 08:52:53 -0300 Message-ID: Subject: Re: [PATCH 1/2] ASoC: fsl_rpmsg: add soc specific data structure To: Shengjiu Wang Content-Type: text/plain; charset="UTF-8" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux-ALSA , Timur Tabi , Xiubo Li , linux-kernel , Takashi Iwai , Jaroslav Kysela , Nicolin Chen , Mark Brown , linuxppc-dev Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi Shengjiu, On Thu, Aug 26, 2021 at 8:19 AM Shengjiu Wang wrote: > + rpmsg->soc_data = of_device_get_match_data(&pdev->dev); > + if (rpmsg->soc_data) { This check is not necessary, because rpmsg->soc_data is always non-NULL. Other than that: Reviewed-by: Fabio Estevam