* [PATCH 2/3] ASoC: fsl_ssi: mark some registers precious
@ 2015-12-20 20:31 Maciej S. Szmigiero
2015-12-23 13:12 ` Fabio Estevam
2016-01-10 21:35 ` Timur Tabi
0 siblings, 2 replies; 3+ messages in thread
From: Maciej S. Szmigiero @ 2015-12-20 20:31 UTC (permalink / raw)
To: alsa-devel@alsa-project.org
Cc: Timur Tabi, Nicolin Chen, Xiubo Li, Liam Girdwood, Mark Brown,
linuxppc-dev@lists.ozlabs.org, linux-kernel, Fabio Estevam
Mark some registers precious since their
reads have side effects (like clearing flags).
Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
---
sound/soc/fsl/fsl_ssi.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
index cc22354d7758..40dfd8a36484 100644
--- a/sound/soc/fsl/fsl_ssi.c
+++ b/sound/soc/fsl/fsl_ssi.c
@@ -157,6 +157,21 @@ static bool fsl_ssi_volatile_reg(struct device *dev, unsigned int reg)
}
}
+static bool fsl_ssi_precious_reg(struct device *dev, unsigned int reg)
+{
+ switch (reg) {
+ case CCSR_SSI_SRX0:
+ case CCSR_SSI_SRX1:
+ case CCSR_SSI_SISR:
+ case CCSR_SSI_SACADD:
+ case CCSR_SSI_SACDAT:
+ case CCSR_SSI_SATAG:
+ return true;
+ default:
+ return false;
+ }
+}
+
static bool fsl_ssi_writeable_reg(struct device *dev, unsigned int reg)
{
switch (reg) {
@@ -179,6 +194,7 @@ static const struct regmap_config fsl_ssi_regconfig = {
.num_reg_defaults = ARRAY_SIZE(fsl_ssi_reg_defaults),
.readable_reg = fsl_ssi_readable_reg,
.volatile_reg = fsl_ssi_volatile_reg,
+ .precious_reg = fsl_ssi_precious_reg,
.writeable_reg = fsl_ssi_writeable_reg,
.cache_type = REGCACHE_RBTREE,
};
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 2/3] ASoC: fsl_ssi: mark some registers precious
2015-12-20 20:31 [PATCH 2/3] ASoC: fsl_ssi: mark some registers precious Maciej S. Szmigiero
@ 2015-12-23 13:12 ` Fabio Estevam
2016-01-10 21:35 ` Timur Tabi
1 sibling, 0 replies; 3+ messages in thread
From: Fabio Estevam @ 2015-12-23 13:12 UTC (permalink / raw)
To: Maciej S. Szmigiero
Cc: alsa-devel@alsa-project.org, Timur Tabi, Nicolin Chen, Xiubo Li,
Liam Girdwood, Mark Brown, linuxppc-dev@lists.ozlabs.org,
linux-kernel
On Sun, Dec 20, 2015 at 6:31 PM, Maciej S. Szmigiero
<mail@maciej.szmigiero.name> wrote:
> Mark some registers precious since their
> reads have side effects (like clearing flags).
>
> Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/3] ASoC: fsl_ssi: mark some registers precious
2015-12-20 20:31 [PATCH 2/3] ASoC: fsl_ssi: mark some registers precious Maciej S. Szmigiero
2015-12-23 13:12 ` Fabio Estevam
@ 2016-01-10 21:35 ` Timur Tabi
1 sibling, 0 replies; 3+ messages in thread
From: Timur Tabi @ 2016-01-10 21:35 UTC (permalink / raw)
To: Maciej S. Szmigiero, alsa-devel@alsa-project.org
Cc: Nicolin Chen, Xiubo Li, Liam Girdwood, Mark Brown,
linuxppc-dev@lists.ozlabs.org, linux-kernel, Fabio Estevam
Maciej S. Szmigiero wrote:
> Mark some registers precious since their
> reads have side effects (like clearing flags).
>
> Signed-off-by: Maciej S. Szmigiero<mail@maciej.szmigiero.name>
Acked-by: Timur Tabi <timur@tabi.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-01-10 21:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-20 20:31 [PATCH 2/3] ASoC: fsl_ssi: mark some registers precious Maciej S. Szmigiero
2015-12-23 13:12 ` Fabio Estevam
2016-01-10 21:35 ` Timur Tabi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).