From: "Oliver O'Halloran" <oohall@gmail.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Andrew Donnellan <andrew.donnellan@au1.ibm.com>,
Matt Brown <matthew.brown.dev@gmail.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v3] powerpc/powernv: add hdat attribute to sysfs
Date: Mon, 27 Feb 2017 22:41:20 +1100 [thread overview]
Message-ID: <CAOSf1CF2-E6eV5bf95qr-uYxcxEdhpLevWbmHW97virJhNxS4g@mail.gmail.com> (raw)
In-Reply-To: <87lgsrrjfb.fsf@concordia.ellerman.id.au>
On Mon, Feb 27, 2017 at 9:56 PM, Michael Ellerman <mpe@ellerman.id.au> wrote:
> Matt Brown <matthew.brown.dev@gmail.com> writes:
>> diff --git a/arch/powerpc/platforms/powernv/opal-hdat.c b/arch/powerpc/platforms/powernv/opal-hdat.c
>> new file mode 100644
>> index 0000000..3315dd3
>> --- /dev/null
>> +++ b/arch/powerpc/platforms/powernv/opal-hdat.c
>> @@ -0,0 +1,65 @@
> ...
>> +
>> +
>> +/* HDAT attribute for sysfs */
>> +static struct bin_attribute hdat_attr = {
>> + .attr = {.name = "hdat", .mode = 0444},
> ^^^^
> ajd and oohal report to my office.
I don't think there's anything in the HDAT that's sensitive. That
said, this might not be true in the future so making it only readable
by root might be a good idea.
Oliver
next prev parent reply other threads:[~2017-02-27 11:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-24 6:20 [PATCH v3] powerpc/powernv: add hdat attribute to sysfs Matt Brown
2017-02-27 1:59 ` Andrew Donnellan
2017-02-27 2:13 ` Oliver O'Halloran
2017-02-27 10:52 ` Michael Ellerman
2017-02-27 10:56 ` Michael Ellerman
2017-02-27 11:41 ` Oliver O'Halloran [this message]
2017-02-28 3:14 ` Michael Ellerman
2017-02-28 23:18 ` Andrew Donnellan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOSf1CF2-E6eV5bf95qr-uYxcxEdhpLevWbmHW97virJhNxS4g@mail.gmail.com \
--to=oohall@gmail.com \
--cc=andrew.donnellan@au1.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=matthew.brown.dev@gmail.com \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).