From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1D30C433E0 for ; Tue, 4 Aug 2020 07:00:05 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 49DB222B40 for ; Tue, 4 Aug 2020 07:00:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cEpKAJv0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 49DB222B40 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4BLQcL3QlpzDqXC for ; Tue, 4 Aug 2020 17:00:02 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::141; helo=mail-il1-x141.google.com; envelope-from=oohall@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=cEpKAJv0; dkim-atps=neutral Received: from mail-il1-x141.google.com (mail-il1-x141.google.com [IPv6:2607:f8b0:4864:20::141]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4BLQZZ2wYpzDqW2 for ; Tue, 4 Aug 2020 16:58:30 +1000 (AEST) Received: by mail-il1-x141.google.com with SMTP id l17so23065572ilq.13 for ; Mon, 03 Aug 2020 23:58:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pIh5KT4J3I0vWN5BTHSBXBuj/RvwuVvx1DEt8ERJDFE=; b=cEpKAJv0CNJmE18UXIFnjn59SrpSMun3BbYDcdjNPS+mASWTKVOiS/YFrWt8Lmdree +jpG6RynI1vL7LOggcJYv0YI4LNdUED3qQECaBl9lifd7pRXQVy1xrK/n8xlsfaUE6WL zXPIlI9btxWrMZaw5nA5RNrSYUrz0IOLmfYLmU5KxiVzAWeTL1JuBOTB3AfsjK8aGzYC TogNVHLb5DebKrp87hG28mU24XImRUVNyIDOYMOiTcMHWe/wMbhPGI96537Cx79gtZkM 6eZADf9L4+dqnAQhcCSZ1MSH9JUcVdHlcmWJWaWVwbT43NpRP5N3ouGND3ChznOSmEDW 5XhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pIh5KT4J3I0vWN5BTHSBXBuj/RvwuVvx1DEt8ERJDFE=; b=nwGG2KMAl9U9fCCcE1s0UlMVoBva8Cc2SJt2r8yhlYoLl/Pyv7yKnQrdjL0v/dLrN7 a8XXLNQ7eB4Ya5V1M3WTR9o8DN7GZP4rykb8mhCrdmvL25W/mqZV0irY16XDh1WdK0Z0 5f3d6uSW8xjPpsF7nscLLWxQ9alCrpsWEbK69PMm0TYNjEifuJYslJeZ66XdkSTjPLHI d9Pss1tDmWMSRwBJ/yOtNJrM7QBbHS7EmstcWz1EILp2ihb4bWYdkSmdruqtiptjdG+D dBr2IUvCYtuA/q+r2BZgZ/aaVN3nHeKAt/DNu620CHEICYC0u4NXIDqJn3wu0abiFQsp w+8w== X-Gm-Message-State: AOAM5317/PT0GFYpRiHNv/GpSvuqTBj9LhVcF3A7PwzhNBt0hGd9h3pU KEUqAVbg9YHyF93vJj8scgdwNpD3tpcL+6T4Ur6XIQ== X-Google-Smtp-Source: ABdhPJwY7PWG6QkBQ8n2pXSVnAfn22MZWg0foUZC3Lg9RjJZIgHkx3aNieTsxEDakSxAk2fhUiEpNB7ZnSaKtMbxXaA= X-Received: by 2002:a05:6e02:148:: with SMTP id j8mr3130405ilr.186.1596524306179; Mon, 03 Aug 2020 23:58:26 -0700 (PDT) MIME-Version: 1.0 References: <20200804005410.146094-1-oohall@gmail.com> <20200804005410.146094-2-oohall@gmail.com> In-Reply-To: From: "Oliver O'Halloran" Date: Tue, 4 Aug 2020 16:58:14 +1000 Message-ID: Subject: Re: [PATCH 1/6] powerpc/powernv/smp: Fix spurious DBG() warning To: Joel Stanley Content-Type: text/plain; charset="UTF-8" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linuxppc-dev Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, Aug 4, 2020 at 12:07 PM Joel Stanley wrote: > > Messy: > > $ git grep "define DBG(" arch/powerpc/ |grep -v print > arch/powerpc/kernel/crash_dump.c:#define DBG(fmt...) > arch/powerpc/kernel/iommu.c:#define DBG(...) > arch/powerpc/kernel/legacy_serial.c:#define DBG(fmt...) do { } while(0) > arch/powerpc/kernel/prom.c:#define DBG(fmt...) > arch/powerpc/kernel/setup-common.c:#define DBG(fmt...) > arch/powerpc/kernel/setup_32.c:#define DBG(fmt...) > arch/powerpc/kernel/smp.c:#define DBG(fmt...) > arch/powerpc/kernel/vdso.c:#define DBG(fmt...) > arch/powerpc/kvm/book3s_hv_rm_xive.c:#define DBG(fmt...) do { } while(0) > arch/powerpc/mm/book3s64/hash_utils.c:#define DBG(fmt...) > arch/powerpc/platforms/83xx/mpc832x_mds.c:#define DBG(fmt...) > arch/powerpc/platforms/83xx/mpc832x_rdb.c:#define DBG(fmt...) > arch/powerpc/platforms/83xx/mpc836x_mds.c:#define DBG(fmt...) > arch/powerpc/platforms/85xx/mpc85xx_ds.c:#define DBG(fmt, args...) > arch/powerpc/platforms/85xx/mpc85xx_mds.c:#define DBG(fmt...) > arch/powerpc/platforms/85xx/mpc85xx_rdb.c:#define DBG(fmt, args...) > arch/powerpc/platforms/86xx/mpc86xx_hpcn.c:#define DBG(fmt...) do { } while(0) > arch/powerpc/platforms/cell/setup.c:#define DBG(fmt...) > arch/powerpc/platforms/cell/smp.c:#define DBG(fmt...) > arch/powerpc/platforms/embedded6xx/mpc7448_hpc2.c:#define DBG(fmt...) > do { } while(0) > arch/powerpc/platforms/maple/pci.c:#define DBG(x...) > arch/powerpc/platforms/maple/setup.c:#define DBG(fmt...) > arch/powerpc/platforms/maple/time.c:#define DBG(x...) > arch/powerpc/platforms/powermac/bootx_init.c:#define DBG(fmt...) do { } while(0) > arch/powerpc/platforms/powermac/feature.c:#define DBG(fmt...) > arch/powerpc/platforms/powermac/low_i2c.c:#define DBG(x...) do {\ > arch/powerpc/platforms/powermac/low_i2c.c:#define DBG(x...) > arch/powerpc/platforms/powermac/nvram.c:#define DBG(x...) > arch/powerpc/platforms/powermac/pci.c:#define DBG(x...) > arch/powerpc/platforms/powermac/pfunc_base.c:#define DBG(fmt...) > arch/powerpc/platforms/powermac/pfunc_core.c:#define DBG(fmt...) > arch/powerpc/platforms/powermac/smp.c:#define DBG(fmt...) > arch/powerpc/platforms/powermac/time.c:#define DBG(x...) > arch/powerpc/platforms/powernv/smp.c:#define DBG(fmt...) > arch/powerpc/sysdev/dart_iommu.c:#define DBG(...) > arch/powerpc/sysdev/ge/ge_pic.c:#define DBG(fmt...) do { } while (0) > arch/powerpc/sysdev/mpic.c:#define DBG(fmt...) > arch/powerpc/sysdev/tsi108_dev.c:#define DBG(fmt...) do { } while(0) > arch/powerpc/sysdev/tsi108_pci.c:#define DBG(x...) I started off writing a patch that fixed all these too. When I went to test it I discovered there's a giant pile of other W=1 warnings from other parts of arch/powerpc/ so I figured I'd start with something less ambitious.