From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-x241.google.com (mail-qt0-x241.google.com [IPv6:2607:f8b0:400d:c0d::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3v2n1s4lBGzDqFb for ; Tue, 17 Jan 2017 21:50:25 +1100 (AEDT) Received: by mail-qt0-x241.google.com with SMTP id l7so20581238qtd.3 for ; Tue, 17 Jan 2017 02:50:25 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <87a8aqau99.fsf@concordia.ellerman.id.au> References: <20170112035413.26544-1-ruscur@russell.cc> <1484293883.2406.1.camel@gmail.com> <87a8aqau99.fsf@concordia.ellerman.id.au> From: "Oliver O'Halloran" Date: Tue, 17 Jan 2017 21:50:20 +1100 Message-ID: Subject: Re: [PATCH] powerpc: Use octal numbers for file permissions To: Michael Ellerman Cc: Russell Currey , linuxppc-dev@lists.ozlabs.org, Cyril Bur Content-Type: multipart/alternative; boundary=001a11c01cd413cae4054648118d List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , --001a11c01cd413cae4054648118d Content-Type: text/plain; charset=UTF-8 "It's possible I missed one, but I did genuinely review all of it" Cyril Bur, 2016 In a hobart pub, specifically The Winston On 17/01/2017 8:53 PM, "Michael Ellerman" wrote: > Cyril Bur writes: > > > On Thu, 2017-01-12 at 14:54 +1100, Russell Currey wrote: > >> Symbolic macros are unintuitive and hard to read, whereas octal > constants > >> are much easier to interpret. Replace macros for the basic permission > >> flags (user/group/other read/write/execute) with numeric constants > >> instead, across the whole powerpc tree. > >> > >> Introducing a significant number of changes across the tree for no > runtime > >> benefit isn't exactly desirable, but so long as these macros are still > >> used in the tree people will keep sending patches that add them. Not > only > >> are they hard to parse at a glance, there are multiple ways of coming to > >> the same value (as you can see with 0444 and 0644 in this patch) which > >> hurts readability. > >> > >> Signed-off-by: Russell Currey > > > > Reviewed-by: Cyril Bur > > Did you really really review every single change? > > Because if you did then I don't have to, and that would be *great* :) > > cheers > --001a11c01cd413cae4054648118d Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

"It's possible I missed one, but I did genuinely re= view all of it"

Cyril Bur, 2016
In a hobart pub, specifically The Winston


On 17/01/2017 8:5= 3 PM, "Michael Ellerman" <mpe@ellerman.id.au> wrote:
Cyril Bur <cyrilbu= r@gmail.com> writes:

> On Thu, 2017-01-12 at 14:54 +1100, Russell Currey wrote:
>> Symbolic macros are unintuitive and hard to read, whereas octal co= nstants
>> are much easier to interpret.=C2=A0 Replace macros for the basic p= ermission
>> flags (user/group/other read/write/execute) with numeric constants=
>> instead, across the whole powerpc tree.
>>
>> Introducing a significant number of changes across the tree for no= runtime
>> benefit isn't exactly desirable, but so long as these macros a= re still
>> used in the tree people will keep sending patches that add them.= =C2=A0 Not only
>> are they hard to parse at a glance, there are multiple ways of com= ing to
>> the same value (as you can see with 0444 and 0644 in this patch) w= hich
>> hurts readability.
>>
>> Signed-off-by: Russell Currey <ruscur@russell.cc>
>
> Reviewed-by: Cyril Bur <cyril= bur@gmail.com>

Did you really really review every single change?

Because if you did then I don't have to, and that would be *great* :)
cheers
--001a11c01cd413cae4054648118d--