From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B04BFC2BA19 for ; Mon, 6 Apr 2020 09:03:56 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 18F1E206B8 for ; Mon, 6 Apr 2020 09:03:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RO6bTnl9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 18F1E206B8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 48wl2d6ydszDqfc for ; Mon, 6 Apr 2020 19:03:53 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::d44; helo=mail-io1-xd44.google.com; envelope-from=oohall@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=RO6bTnl9; dkim-atps=neutral Received: from mail-io1-xd44.google.com (mail-io1-xd44.google.com [IPv6:2607:f8b0:4864:20::d44]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 48wl0N52rPzDqN2 for ; Mon, 6 Apr 2020 19:01:55 +1000 (AEST) Received: by mail-io1-xd44.google.com with SMTP id o3so14987997ioh.2 for ; Mon, 06 Apr 2020 02:01:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=pPm6etZ3DUUwdeDCq5weBWVRzrJKUcDMh1m6LaRUmg0=; b=RO6bTnl9ZO8chRFxwBeCgpSPjiaXGSo/VIogGReccYaReJrAqlGbeuPXi1/pb4+D// 8TT4Lv9F13EkLo1Gwk60cf0zhFjSrwuT6Ul+RFDalmwEh5ktCIw1nTvXsuLpMcrx2nGg CIbYnUxlAtzBZ1ZjFl3/iLVRzXV0p27M19WUsjeJn29dtx1eNTXiDnapuGtguKXqBW0r 4S8aYm8e1cLhhM9agl0Z7zlIiq4GkfmWD+QWL/js/9UrbZ+Rnrhunypu3uGV7EB2oSN5 Vg3wtiIIjMH+vQOajOslPnZDUii4fDuMSTIzExnmx3lbfIYqMFIyRIS4LxBIsYwoaBVR iaWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=pPm6etZ3DUUwdeDCq5weBWVRzrJKUcDMh1m6LaRUmg0=; b=ftE1etmNfGpHdVX9AB/XVWrIr+KexbrA1l6RKzEJerSLYbHM6qKqWm6kCefVl+DZFX WbSp93vU0KF6ahJLVeEYhiOD9I3JNCnQ+X/gLjBPclv3/rExu6sr0Z8ulI+xkg0ysmC0 pG5Yl/CE3IjwEnL/4ZPQOHGe6mNHpgY2gdtVV7YHMwz24jKuSMF+Qm24tJokRMTNkWWX PLCzScQ3wW7DmfeEvLi5AT9xWLPfefZonT/aw5qpvcM8fe0ICRlssanbSzlSbUfbXmL4 E30+e7vzOVkFNhF9iB6cltg4w50/i+LiGhBh0JXI9K3AWH7AygPwSo6R0ACsgaBItAzb rMfw== X-Gm-Message-State: AGi0PubcPw34eJN+jMiK7spCGcbKfS/6IojByGluoPMRqHEG1nQ3ELDa 7Ju8Ml21CA4DGgaoZj6/OujOlymMF3jfQjUH9d8= X-Google-Smtp-Source: APiQypLku0LYgnaIgBugI+M3YhMRY6xZpLQ6kvGHLYNz1gKDqsMI0LsZRNJJvk7btsnOIpyZBTM50rTOlldIgmCnN5A= X-Received: by 2002:a02:390b:: with SMTP id l11mr19599417jaa.111.1586163712467; Mon, 06 Apr 2020 02:01:52 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: "Oliver O'Halloran" Date: Mon, 6 Apr 2020 19:01:41 +1000 Message-ID: Subject: Re: [PATCH v3] powerpc/powernv: add NULL check after kzalloc in opal_add_one_export To: Qiujun Huang Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paul Mackerras , Thomas Gleixner , linuxppc-dev , Markus Elfring , LKML Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, Apr 6, 2020 at 11:15 AM Qiujun Huang wrote: > > On Mon, Apr 6, 2020 at 3:06 AM Markus Elfring wro= te: > > > > > Here needs a NULL check. > quite obvious? > > > > I find this change description questionable > > (despite of a reasonable patch subject). > > > > > > > Issue found by coccinelle. > > > > Would an information like =E2=80=9CGenerated by: scripts/coccinelle/nul= l/kmerr.cocci=E2=80=9D > > be nicer? > Yeah, but I think It was enough. I didn't know we had that script in the kernel tree so I think it's a good to mention that you used it. It might even help idiots like me who write this sort of bug. > > Will a patch change log be helpful here? > I realized I should write some change log, and the change log was meaning= less. > So I left it blank. The changelog is fine IMO. The point of a changelog is to tell a reader doing git archeology why a change happened and this is sufficent for that. Reviewed-by: Oliver O'Halloran