Re: [PATCH v2] powerpc/boot: Add OPAL console to epapr wrappers

[oliver <oohall@gmail.com>]

On Mon, Jun 27, 2016 at 2:38 PM, Stewart Smith
<stewart@linux.vnet.ibm.com> wrote:
> Oliver O'Halloran <oohall@gmail.com> writes:
> One thing to think of is if we really need anything printed except the
> error message. Out of these three lines of output (for a corrupted
> zImage.epapr), only the last line gives any real information.
>
> 5343492: (5343490): zImage starting: loaded at 0x0000000020010000 (sp: 0x0000000020ee2ed8)
> 5507562: (5507560): Allocating 0x159efd4 bytes for kernel ...
> 5557104: (5557102): gunzipping (0x0000000000000000 <- 0x000000002001e000:0x0000000020ee05c0)...inflate returned -3 msg: invalid block type
>
> Although this should likely be addressed in another patch.

None of this is useful to us since we get most of this information
from skiboot, but I'm not sure that's true for other platforms. The
kernel boot log is fairly noisy as-is so we don't gain much from
trimming. At the very least the other messages provide sanity checks
that we've exited firmware and/or the bootloader without issues. I'll
look at changing the returned error messages though, "invalid block
type" is a pretty error useless you already know what you're looking
for.

> Needs (C) header.

There's always something missing ;)