From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A8C0C48BE8 for ; Fri, 18 Jun 2021 07:22:20 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0D0436109D for ; Fri, 18 Jun 2021 07:22:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D0436109D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4G5r3G6nmmz3c5w for ; Fri, 18 Jun 2021 17:22:18 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=MgJa/mVt; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::f33; helo=mail-qv1-xf33.google.com; envelope-from=oohall@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=MgJa/mVt; dkim-atps=neutral Received: from mail-qv1-xf33.google.com (mail-qv1-xf33.google.com [IPv6:2607:f8b0:4864:20::f33]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4G5r2h2J4Xz2xfY for ; Fri, 18 Jun 2021 17:21:47 +1000 (AEST) Received: by mail-qv1-xf33.google.com with SMTP id g19so211625qvx.12 for ; Fri, 18 Jun 2021 00:21:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AseZqmRRFSAWxlkl2H15IzgmyWSQsQrTGUE3obWRyrM=; b=MgJa/mVtq6XWZKn0imgyglg6ZDupmBYLsc6nqx+ZO1zknwhEReGKbW0bIN9kjCm914 7E0WAR6WoiSOPVxaB4Sadr237fXQYjs9EIPdgHjw9yI7oCPSKi4s9wk8qO8viYfzO3j3 oX+nQ93PDsxTTWGmQ+zEoHHEzIbrkCpmblgepC5prfbUg/gCfpWMcO/C4y9jHTrhS7J9 aDBO2TOUCs0o7DhFQLYvBcSNaj7d6xtPRM96we9l/KZVn0ibRSkALFFBsZamfIFH6mcS yO9FBRCXYYW6AVbx1b8Fo3NeTpoSHj0kqJzDZ75OBnVurCO3pnFCMY6pcN+WXE9z1ab5 BNWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AseZqmRRFSAWxlkl2H15IzgmyWSQsQrTGUE3obWRyrM=; b=eVlE4xjmDeJXHxFt6RnTk2roCxsPjwJmti+PKH/2I3hKS3U5rHCud+WgwddzAwO7m6 hHlQPNetpCC3qbWMrKSN1e7XvRSKF8xkvVuJa0/GNYTQ3+6jQo0+tElWa/wMTjhm/Xby AwpMCtHznZJkbUtu8rGYwqS4YAdeCEAZp8wltT6rzw0FINOr7Q05oOGIaztTUo+/CLje DgE/TPhjjDVD7JSZE+sKmyvdWbC4nxMn3rWxcVCNa6nCsjConxFCberX62FpQjRY+1ed xL4znNgH9ZysGxRTJ7F2HNL6jirLSeZFJBQUZ+0xOiOQtj5G0P+RlpbQ7oG4/YVilCfq 18TQ== X-Gm-Message-State: AOAM533Dk/ZT5RsRUToqjC+8z+ifjQyGkwY+keMWDdTbWxuHFJbQCWVy vi2nQKAMqsPqy8WfhxVguw6POOO+TjGeOqnp4mg= X-Google-Smtp-Source: ABdhPJzI+iK7/41znGGgZl/dbRcTtghUb49l1y3drihvMzNc/ZojRa6nxa5QP29LX6atdU7DeSKN+KsCA9Lpx5XaGQY= X-Received: by 2002:a0c:f982:: with SMTP id t2mr4206794qvn.28.1624000902896; Fri, 18 Jun 2021 00:21:42 -0700 (PDT) MIME-Version: 1.0 References: <20210618060446.7969-1-wesley.sheng@amd.com> In-Reply-To: <20210618060446.7969-1-wesley.sheng@amd.com> From: "Oliver O'Halloran" Date: Fri, 18 Jun 2021 17:21:32 +1000 Message-ID: Subject: Re: [PATCH] Documentation: PCI: pci-error-recovery: rearrange the general sequence To: Wesley Sheng Content-Type: text/plain; charset="UTF-8" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: wesleyshenggit@sina.com, Jonathan Corbet , linux-pci , linux-doc@vger.kernel.org, Linux Kernel Mailing List , Bjorn Helgaas , linasvepstas@gmail.com, linuxppc-dev Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, Jun 18, 2021 at 4:05 PM Wesley Sheng wrote: > > Reset_link() callback function was called before mmio_enabled() in > pcie_do_recovery() function actually, so rearrange the general > sequence betwen step 2 and step 3 accordingly. I don't think this is true in all cases. If pcie_do_recovery() is called with state==pci_channel_io_normal (i.e. non-fatal AER) the link won't be reset. EEH (ppc PCI error recovery thing) also uses .mmio_enabled() as described.