From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ie0-f172.google.com (mail-ie0-f172.google.com [209.85.223.172]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 65E801A030A for ; Wed, 15 Oct 2014 17:38:52 +1100 (EST) Received: by mail-ie0-f172.google.com with SMTP id rl12so610636iec.17 for ; Tue, 14 Oct 2014 23:38:50 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20141015020811.7904E14011B@ozlabs.org> References: <1412919926-13123-1-git-send-email-vvijayan@mvista.com> <20141015020811.7904E14011B@ozlabs.org> From: Vineeth Vijayan Date: Wed, 15 Oct 2014 12:08:29 +0530 Message-ID: Subject: Re: powerpc: Fix Text randomization To: Michael Ellerman Content-Type: text/plain; charset=UTF-8 Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Oct 15, 2014 at 7:38 AM, Michael Ellerman wrot= e: > On Fri, 2014-10-10 at 05:45:26 UTC, Vineeth Vijayan wrote: >> Right now there is no way to disable TEXT randomization on a PPC32 >> machine. text randomization happens even in the case of "echo 0 > >> /proc/sys/kernel/randomize_va_space" > > Yeah it seems to happen on ppc64 too. > >> This happens due to the incorrect definition of ELF_ET_DYN_BASE at >> arch/powerpc/include/asm/elf.h > > What is incorrect about it? We are not the only arch that does that. > I think we are one of the arch which does it. The same has been tested on x86 and arm, where ELF_ET_DYN_BASE doesn=E2=80= =99t use randomize_et_dyn call, and it works properly as per the user-space definition of randomization; (i.e when at "echo 0 > /proc/sys/kernel/randomize_va_space", TEXT randomization should not happen.) > I'm not clear on what has changed to break this? > > cheers